'Re: Review Request: Text is rendered only for the first page in text'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Text is rendered only for the first page in text
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-09-29 14:05:31
Message-ID: 20100929140531.16179.46977 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5466/#review7875
-----------------------------------------------------------

I'm pretty sure most documents render more than one page without issues; so=
 please in order to make a patch review clear you should state the problem =
you are seeing which is fixed using this change. As my repeated requests fo=
r a unit test have been ignored you should at minimum give a good reason fo=
r a change.  Something that is quite easy to do using a unit test!

In this case the change looks pretty harmless so if you clean it up (remove=
 the qdebug etc) then I guess its Ok to commit.

- Thomas

On 2010-09-28 13:11:14, Pavol Korinek wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5466/
> -----------------------------------------------------------
> =

> (Updated 2010-09-28 13:11:14)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> Text is rendered for all pages with this patch. newShape boolean variable=
 should not be set to true, when no next shape was in container.
> =

> =

> Diffs
> -----
> =

>   /trunk/koffice/plugins/textshape/Layout.cpp 1180481 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5466/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Pavol
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5466/">http://svn.reviewboard.kde.org/r/5466/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;m pretty sure most \
documents render more than one page without issues; so please in order to make a \
patch review clear you should state the problem you are seeing which is fixed using \
this change. As my repeated requests for a unit test have been ignored you should at \
minimum give a good reason for a change.  Something that is quite easy to do using a \
unit test!

In this case the change looks pretty harmless so if you clean it up (remove the \
qdebug etc) then I guess its Ok to commit.</pre>  <br />

<p>- Thomas</p>

<br />
<p>On September 28th, 2010, 1:11 p.m., Pavol Korinek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>

<p style="color: grey;"><i>Updated 2010-09-28 13:11:14</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Text is rendered for all pages with this patch. newShape boolean \
variable should not be set to true, when no next shape was in container.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1180481)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5466/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 