I'm pretty sure most documents render more than one page without issues; so please in order to make a patch review clear you should state the problem you are seeing which is fixed using this change. As my repeated requests for a unit test have been ignored you should at minimum give a good reason for a change.  Something that is quite easy to do using a unit test!

In this case the change looks pretty harmless so if you clean it up (remove the qdebug etc) then I guess its Ok to commit.

- Thomas

On September 28th, 2010, 1:11 p.m., Pavol Korinek wrote:

Text is rendered for all pages with this patch. newShape boolean variable should not be set to true, when no next shape was in container.