From koffice-devel Wed Sep 29 14:05:31 2010 From: "Thomas Zander" Date: Wed, 29 Sep 2010 14:05:31 +0000 To: koffice-devel Subject: Re: Review Request: Text is rendered only for the first page in text Message-Id: <20100929140531.16179.46977 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128576916621699 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1017597884==" --===============1017597884== Content-Type: multipart/alternative; boundary="===============7343586816646917552==" --===============7343586816646917552== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5466/#review7875 ----------------------------------------------------------- I'm pretty sure most documents render more than one page without issues; so= please in order to make a patch review clear you should state the problem = you are seeing which is fixed using this change. As my repeated requests fo= r a unit test have been ignored you should at minimum give a good reason fo= r a change. Something that is quite easy to do using a unit test! In this case the change looks pretty harmless so if you clean it up (remove= the qdebug etc) then I guess its Ok to commit. - Thomas On 2010-09-28 13:11:14, Pavol Korinek wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5466/ > ----------------------------------------------------------- > = > (Updated 2010-09-28 13:11:14) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Text is rendered for all pages with this patch. newShape boolean variable= should not be set to true, when no next shape was in container. > = > = > Diffs > ----- > = > /trunk/koffice/plugins/textshape/Layout.cpp 1180481 = > = > Diff: http://svn.reviewboard.kde.org/r/5466/diff > = > = > Testing > ------- > = > = > Thanks, > = > Pavol > = > --===============7343586816646917552== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5466/ 

I'm pr=
etty sure most documents render more than one page without issues; so pleas=
e in order to make a patch review clear you should state the problem you ar=
e seeing which is fixed using this change. As my repeated requests for a un=
it test have been ignored you should at minimum give a good reason for a ch=
ange.  Something that is quite easy to do using a unit test!

In this case the change looks pretty harmless so if you clean it up (remove=
 the qdebug etc) then I guess its Ok to commit.

- Thomas


On September 28th, 2010, 1:11 p.m., Pavol Korinek wrote:

Review request for KOffice.
By Pavol Korinek.

Updated 2010-09-28 13:11:14

Descripti= on 

Text is rendered for all pages with this patch. newShape boo=
lean variable should not be set to true, when no next shape was in containe=
r.

Diffs=

  • /trunk/koffice/plugins/textshape/Layout.cpp View Diff
--===============7343586816646917552==-- --===============1017597884== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1017597884==--