[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix for rendering all the pages to CanvasItem
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-09-25 10:13:38
Message-ID: 20100925101338.25818.93594 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5437/#review7774
-----------------------------------------------------------
The commit looks a bit alient to me since I have no clue about the canvas y=
ou are using here. It looks like you are not using the magic-curtain which =
would lead to incorrectly positioned shapes.
I'd suggest committing this on the feature branch as there is no bug fixed =
in the main branch and after unfreeze we might look for a better solution t=
hat doens't force a hack like this.
- Thomas
On 2010-09-24 09:59:43, Mani Chandrasekar wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5437/
> -----------------------------------------------------------
> =
> (Updated 2010-09-24 09:59:43)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> As we do not create KWView while using KWCanvasItem. So this will not add=
shapeManager to the shape.
> =
> So When Canvas is being updated, Only the first page is rendered. As othe=
r pages doen't have shapeManager =
> shapeManager condition in void KoShape::update(const QRectF &shape) const=
will never pass.
> =
> If we do not have any View, then we can check if CanvasItem and add manag=
er to the shape. =
> =
> =
> Diffs
> -----
> =
> trunk/koffice/kword/part/KWDocument.cpp 1177782 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5437/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Mani
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5437/">http://svn.reviewboard.kde.org/r/5437/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The commit looks a bit \
alient to me since I have no clue about the canvas you are using here. It looks like \
you are not using the magic-curtain which would lead to incorrectly positioned \
shapes. I'd suggest committing this on the feature branch as there is no bug \
fixed in the main branch and after unfreeze we might look for a better solution that \
doens't force a hack like this.</pre> <br />
<p>- Thomas</p>
<br />
<p>On September 24th, 2010, 9:59 a.m., Mani Chandrasekar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Mani Chandrasekar.</div>
<p style="color: grey;"><i>Updated 2010-09-24 09:59:43</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As we do not create KWView while using KWCanvasItem. So this will not \
add shapeManager to the shape.
So When Canvas is being updated, Only the first page is rendered. As other pages \
doen't have shapeManager shapeManager condition in void KoShape::update(const \
QRectF &shape) const will never pass.
If we do not have any View, then we can check if CanvasItem and add manager to the \
shape. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/kword/part/KWDocument.cpp <span style="color: \
grey">(1177782)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5437/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic