'Review Request: Fix for rendering all the pages to CanvasItem'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Fix for rendering all the pages to CanvasItem
From:       "Mani Chandrasekar" <maninc () gmail ! com>
Date:       2010-09-24 9:59:43
Message-ID: 20100924095943.698.75715 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5437/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

As we do not create KWView while using KWCanvasItem. So this will not add s=
hapeManager to the shape.

So When Canvas is being updated, Only the first page is rendered. As other =
pages doen't have shapeManager =

shapeManager condition in void KoShape::update(const QRectF &shape) const w=
ill never pass.

If we do not have any View, then we can check if CanvasItem and add manager=
 to the shape. =

Diffs
-----

  trunk/koffice/kword/part/KWDocument.cpp 1177782 =

Diff: http://svn.reviewboard.kde.org/r/5437/diff

Testing
-------

Thanks,

Mani

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5437/">http://svn.reviewboard.kde.org/r/5437/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Mani Chandrasekar.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As we do not create KWView while using KWCanvasItem. So this will not \
add shapeManager to the shape.

So When Canvas is being updated, Only the first page is rendered. As other pages \
doen&#39;t have shapeManager  shapeManager condition in void KoShape::update(const \
QRectF &amp;shape) const will never pass.

If we do not have any View, then we can check if CanvasItem and add manager to the \
shape. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/kword/part/KWDocument.cpp <span style="color: \
grey">(1177782)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5437/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 