[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: rename dirtyRegion into takeDirtRegion
From: pentalis () gmail ! com
Date: 2010-09-24 18:27:40
Message-ID: 20100924182740.10465.96537 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5441/#review7766
-----------------------------------------------------------
The name change makes sense (though I didn't ensure the code does what you =
said, I'm taking your word :-) ).
Just remember to update the Apidoc as I suggest below.
/trunk/koffice/krita/image/kis_painter.h
<http://svn.reviewboard.kde.org/r/5441/#comment7917>
Please update this apidoc to better describe what the function does, an=
d to use the name takeDirtyRegion() too.
- Pentalis
On 2010-09-24 18:05:09, Adam C. wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5441/
> -----------------------------------------------------------
> =
> (Updated 2010-09-24 18:05:09)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> the name dirtRegion is misleading, as it doesn't imply, that the region g=
ets erased in the same method.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/krita/benchmarks/kis_floodfill_benchmark.cpp 1179150 =
> /trunk/koffice/krita/benchmarks/kis_gradient_benchmark.cpp 1179150 =
> /trunk/koffice/krita/image/kis_painter.h 1179150 =
> /trunk/koffice/krita/image/kis_painter.cc 1179150 =
> /trunk/koffice/krita/image/recorder/kis_recorded_paint_action.cpp 11791=
50 =
> /trunk/koffice/krita/image/tests/kis_projection_test.cpp 1179150 =
> /trunk/koffice/krita/plugins/extensions/painterlyframework/mixertool.cp=
p 1179150 =
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_brush.cc 11791=
50 =
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_ellipse.cc 117=
9150 =
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_fill.cc 117915=
0 =
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_line.cc 117915=
0 =
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_path.cc 117915=
0 =
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_rectangle.cc 1=
179150 =
> /trunk/koffice/krita/plugins/tools/tool_dyna/kis_tool_dyna.cpp 1179150 =
> /trunk/koffice/krita/plugins/tools/tool_polygon/kis_tool_polygon.cc 117=
9150 =
> /trunk/koffice/krita/plugins/tools/tool_polyline/kis_tool_polyline.cc 1=
179150 =
> /trunk/koffice/krita/plugins/tools/tool_star/kis_tool_star.cc 1179150 =
> /trunk/koffice/krita/ui/tool/kis_tool_freehand_p.cpp 1179150 =
> /trunk/koffice/krita/ui/widgets/kis_scratch_pad.cpp 1179150 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5441/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Adam
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5441/">http://svn.reviewboard.kde.org/r/5441/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The name change makes \
sense (though I didn't ensure the code does what you said, I'm taking your \
word :-) ). Just remember to update the Apidoc as I suggest below.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5441/diff/1/?file=37241#file37241line307" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/koffice/krita/image/kis_painter.h</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">307</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \
update, but you can call dirtyRegion() to get the region that needs to be notified by \
your</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">307</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; "><span class="cm"> * update, but you can call dirtyRegion() to get the region \
that needs to be notified by your</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">308</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \
painting code.</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">308</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="cm"> * painting \
code.</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">309</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> \
*</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">309</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; "><span class="cm"> *</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">310</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Call \
will RESET the dirtyRegion!</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">310</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Call \
will RESET the dirtyRegion!</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">311</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> \
*/</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">311</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; "><span class="cm"> */</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">312</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QRegion</span> <span class="n"><span \
class="hl">d</span>irtyRegion</span><span class="p">();</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">312</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QRegion</span> <span class="n"><span \
class="hl">takeD</span>irtyRegion</span><span class="p">();</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">313</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">313</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
update this apidoc to better describe what the function does, and to use the name \
takeDirtyRegion() too.</pre> </div>
<br />
<p>- Pentalis</p>
<br />
<p>On September 24th, 2010, 6:05 p.m., Adam C. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam C..</div>
<p style="color: grey;"><i>Updated 2010-09-24 18:05:09</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the name dirtRegion is misleading, as it doesn't imply, that the \
region gets erased in the same method.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/krita/benchmarks/kis_floodfill_benchmark.cpp <span style="color: \
grey">(1179150)</span></li>
<li>/trunk/koffice/krita/benchmarks/kis_gradient_benchmark.cpp <span style="color: \
grey">(1179150)</span></li>
<li>/trunk/koffice/krita/image/kis_painter.h <span style="color: \
grey">(1179150)</span></li>
<li>/trunk/koffice/krita/image/kis_painter.cc <span style="color: \
grey">(1179150)</span></li>
<li>/trunk/koffice/krita/image/recorder/kis_recorded_paint_action.cpp <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/image/tests/kis_projection_test.cpp <span style="color: \
grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/extensions/painterlyframework/mixertool.cpp <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_brush.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_ellipse.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_fill.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_line.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_path.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_rectangle.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/tool_dyna/kis_tool_dyna.cpp <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/tool_polygon/kis_tool_polygon.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/tool_polyline/kis_tool_polyline.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/plugins/tools/tool_star/kis_tool_star.cc <span \
style="color: grey">(1179150)</span></li>
<li>/trunk/koffice/krita/ui/tool/kis_tool_freehand_p.cpp <span style="color: \
grey">(1179150)</span></li>
<li>/trunk/koffice/krita/ui/widgets/kis_scratch_pad.cpp <span style="color: \
grey">(1179150)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5441/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic