From koffice-devel Sat Sep 25 10:13:38 2010 From: "Thomas Zander" Date: Sat, 25 Sep 2010 10:13:38 +0000 To: koffice-devel Subject: Re: Review Request: Fix for rendering all the pages to CanvasItem Message-Id: <20100925101338.25818.93594 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128540965805027 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1654744570==" --===============1654744570== Content-Type: multipart/alternative; boundary="===============8230102814279115553==" --===============8230102814279115553== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5437/#review7774 ----------------------------------------------------------- The commit looks a bit alient to me since I have no clue about the canvas y= ou are using here. It looks like you are not using the magic-curtain which = would lead to incorrectly positioned shapes. I'd suggest committing this on the feature branch as there is no bug fixed = in the main branch and after unfreeze we might look for a better solution t= hat doens't force a hack like this. - Thomas On 2010-09-24 09:59:43, Mani Chandrasekar wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5437/ > ----------------------------------------------------------- > = > (Updated 2010-09-24 09:59:43) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > As we do not create KWView while using KWCanvasItem. So this will not add= shapeManager to the shape. > = > So When Canvas is being updated, Only the first page is rendered. As othe= r pages doen't have shapeManager = > shapeManager condition in void KoShape::update(const QRectF &shape) const= will never pass. > = > If we do not have any View, then we can check if CanvasItem and add manag= er to the shape. = > = > = > Diffs > ----- > = > trunk/koffice/kword/part/KWDocument.cpp 1177782 = > = > Diff: http://svn.reviewboard.kde.org/r/5437/diff > = > = > Testing > ------- > = > = > Thanks, > = > Mani > = > --===============8230102814279115553== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5437/ 

The commit=
 looks a bit alient to me since I have no clue about the canvas you are usi=
ng here. It looks like you are not using the magic-curtain which would lead=
 to incorrectly positioned shapes.
I'd suggest committing this on the feature branch as there is no bug fi=
xed in the main branch and after unfreeze we might look for a better soluti=
on that doens't force a hack like this.

- Thomas


On September 24th, 2010, 9:59 a.m., Mani Chandrasekar wrote:

Review request for KOffice.
By Mani Chandrasekar.

Updated 2010-09-24 09:59:43

Descripti= on 

As we do not create KWView while using KWCanvasItem. So this=
 will not add shapeManager to the shape.

So When Canvas is being updated, Only the first page is rendered. As other =
pages doen't have shapeManager =

shapeManager condition in void KoShape::update(const QRectF &shape) con=
st will never pass.

If we do not have any View, then we can check if CanvasItem and add manager=
 to the shape.

Diffs=

  • trunk/koffice/kword/part/KWDocument.cpp (1= 177782)

View Diff
--===============8230102814279115553==-- --===============1654744570== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1654744570==--