[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Integrated subset of make_it_cool
From:       Don Sanders <sanders () kde ! org>
Date:       2002-12-27 3:33:38
[Download RAW message or body]

Hi All,

I just committed some code to cvs, there's no reason why we can't 
still discuss it right?

I'm _ok_ with discussing the changes I've made to cvs. Let me explain:

I forked the make_it_cool branch out of cvs on or near Nov 30. I made 
a copy of the cvs tree at that date and I have a copy of the 
CVS/Entries file with all the version numbers.

Then over the next month I've integrated in bug fixes from 
make_it_cool. I can post a diff of those bugs fixes.

Then I merged in the changes in the 3_1_BRANCH I can post a diff of 
those changes too (let me do some work now, I can post these changes, 
and a list of which version of which files I integrated after work)

So we can get a precise description of the changes made and identity 
which changes on your list I've already integrated.

Finally committing the code to cvs also allows users to test in 
parallel as we discuss the changes merged in ok? And that's what I 
want I want to get actual feedback from users, peer review of patches 
is useful but it's not a substitute for actual testing of the app.

However as a KMail Maintainer I do feel that it is appropriate for me 
to participate in the kroupware merging. But perhaps instead of 
committing it would be better if I take patches against the 
3_1_BRANCH rework them against HEAD and post them to the list?

What do you guys think?

Don.

On Friday 27 December 2002 03:57, Zack Rusin wrote:
> On Thursday 26 December 2002 03:32, don@sanders.org wrote:
> > I've integrated a subset of the make_it_cool changes into HEAD.
>
> Hmm, I'm not sure what to say. Personally I'm rather pissed because
> I've spent a good few hours extracting the patches from
> make_it_cool to adopt to the small diff strategy. Marc has spent a
> lot more on it so I can imagine that he's more unhappy than I am.
>
> I'm pissed because that has been a perfectly valid KDE coding time
> wasted. If I haven't been doing the merging I'd finish the
> transparency patch for the Kicker and worked on the new tab widget.
> Now it seems like that was a time I could've spent watching TV and
> it would be just as productive for KDE and KMail (meaning - not at
> all).
>
> But I expressed many times over, that while on this list my only
> concern is the mail client. So the question is: how it works and
> how it has been merged. I need to go out right now and will be back
> in about 6 hours so that's when I'll start testing this. I'm
> postponing my judgment to make sure it's fair towards the mail
> client, not my personal feelings. As soon I'll be back I'll start
> testing it out and once I'll feel like I've spent enough time with
> KMail in its new state I'll send another email saying what I think.
>
> Zack

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]