[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Form Completion
From:       Dawit Alemayehu <adawit () kde ! org>
Date:       2001-03-10 7:54:26
[Download RAW message or body]

On Saturday 10 March 2001 00:30, Malte Starostik wrote:
> Am Samstag 10 März 2001 00:23 schrieb Dawit Alemayehu:
> > On Friday 09 March 2001 15:30, Malte Starostik wrote:
> > > Hello,
> > >
> > > as suggested by Tackat on IRC I tried myself on form completion as in
> > > IE 5 for KHTML. The attached patch does this, seems to work okay, but
> > > I'm not sure if I put it into the Right Places (pat. pending). Does it
> > > look okay to commit or should it be done in a different place?
> > > -Malte
> >
> > I did not know the khtml form used KLineEdit and KCombobox....
> > Anyways, one thing I noticed that I have reservations about is
> >
> > edit->completionObject()->setItems(static_cast<KHTMLView*>(view)->formCom
> >pl etionItems(element->name().string()));
> >
> > this looks like a KLineEdit call and means that a completion object is
> > going to be created for all input widgets on a page.  This IMHO is too
> > expensive specially on web-pages with large input fields.  The best thing
> > to do here is to create the completion object and share it among all the
> > created widgets and delete it when you are done with it...
>
> Well, I did not try how Mozilla does from-completion, but IE (accoring to
> my own tests as well as descriptions of this feature does completion based
> on the form field's name,

Ahhh... I see then what you did makes perfect sense... :)

> so a common completion object would not achieve this.

Right :)

> I thought about one completion object for one form, but then decided
> it would be more overhead to seperate between input-names than to have one
> completion object for every text-input, maybe I'm wrong here.

Hmmm... hard to say.  It is probably comparable :)  One issue here however is 
that it would mean that if all you do is enter username/password, you have to 
do it at least once for all the places where you have to enter this info 
before you get a completion match, right ?  Then that would sort of be 
counter-productive.  Hmmm... perhaps I should shut up before I test how this 
stuff works :)

BTW, you know you are going to have to write a config option for this,
sometime down the line right ? :)  Or simply enable the completion mode 
changer and save the setting such that the user can choose the completion 
mode to use.  BTW this can be no completion mode as well. 

Anwyays, instead of complaining first I should have said excellent work!  I 
think you just made the hearts of a lot of users burst with joy since this 
was one of the more often requested feature... :)

Regards,
Dawit A.

[prev in list] [next in list] [prev in thread] [next in thread]