[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Wrong icons selected after pasting files and renaming them (because there exists
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2013-01-03 9:02:18
Message-ID: 20130103090218.26150.51667 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107351/#review24546
-----------------------------------------------------------
First of all, happy new year and sorry for the late response, real life kept me quite \
busy around Christmas and New Year.
I'm fine with the Dolphin part of the change. About the issue concerning "Why have \
two methods instead of one?" raised by David: Sounds reasonable, one method is really \
sufficient, I think.
About the possible performance problem mentioned by David: I hadn't thought about \
that earlier. I will most likely not create a performance problem in Dolphin, given \
that the slot connected to urlPasted(KUrl) doesn't do anything expensive, but as soon \
as the signal is there, other apps might consider using it as well, and we don't know \
what they will do in slots connected to that signal. So it might indeed be worth \
looking into the possibility of emitting the signal for a bunch of URLs at once, if \
that is doable.
Thanks again for your awesome work. I know that may be a lot more work that one might \
have expected at first sight, but I'm sure that our users will greatly appreciate the \
result once it's finished.
- Frank Reininghaus
On Dec. 13, 2012, 11:42 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107351/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2012, 11:42 p.m.)
>
>
> Review request for Dolphin, David Faure and Frank Reininghaus.
>
>
> Description
> -------
>
> Bug 233335 - Wrong icons selected after pasting files and renaming them (because \
> there exists items with it's names)
> Dolphin 2.1 selects the existing items instead of the newly pasted + renamed items.
>
>
> This addresses bug 233335.
> http://bugs.kde.org/show_bug.cgi?id=233335
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.cpp 11e03d0
> dolphin/src/dolphinviewcontainer.cpp c27550a
> dolphin/src/panels/folders/folderspanel.cpp 6e3a767
> dolphin/src/panels/places/placespanel.cpp 61c15a7
> dolphin/src/views/dolphinview.h a2fe9f6
> dolphin/src/views/dolphinview.cpp 941083f
> dolphin/src/views/draganddrophelper.h ac16f7c
> dolphin/src/views/draganddrophelper.cpp f81d4d0
> lib/konq/konq_operations.h b82feb4
> lib/konq/konq_operations.cpp e0f1ade
>
> Diff: http://git.reviewboard.kde.org/r/107351/diff/
>
>
> Testing
> -------
>
> 1. Open a test folder with Dolphin.
> 2. Create the test files:
> 2.1. Open Dolphin's terminal (F4).
> 2.2. Run "mkdir folder ; touch a b folder/b c d".
> 2.3. Close Dolphin's terminal (F4).
> 3. In the current folder, select the four empty files (a, b, c, d) and copy them \
> (Ctrl+C). 4. Enter the "folder" folder.
> 5. Paste the files (Ctrl+V).
> 5.1. When asked for a new name for "b", enter "b2" and hit Enter to continue.
>
> Result:
> Items "a", "b2", "c", "d" are selected
>
> Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107351/">http://git.reviewboard.kde.org/r/107351/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of all, happy new \
year and sorry for the late response, real life kept me quite busy around Christmas \
and New Year.
I'm fine with the Dolphin part of the change. About the issue concerning \
"Why have two methods instead of one?" raised by David: Sounds reasonable, \
one method is really sufficient, I think.
About the possible performance problem mentioned by David: I hadn't thought about \
that earlier. I will most likely not create a performance problem in Dolphin, given \
that the slot connected to urlPasted(KUrl) doesn't do anything expensive, but as \
soon as the signal is there, other apps might consider using it as well, and we \
don't know what they will do in slots connected to that signal. So it might \
indeed be worth looking into the possibility of emitting the signal for a bunch of \
URLs at once, if that is doable.
Thanks again for your awesome work. I know that may be a lot more work that one might \
have expected at first sight, but I'm sure that our users will greatly appreciate \
the result once it's finished.</pre> <br />
<p>- Frank</p>
<br />
<p>On December 13th, 2012, 11:42 p.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, David Faure and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2012, 11:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug 233335 - Wrong icons selected after pasting files and renaming them \
(because there exists items with it's names)
Dolphin 2.1 selects the existing items instead of the newly pasted + renamed \
items.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Open a test folder with Dolphin. 2. Create the test files:
2.1. Open Dolphin's terminal (F4).
2.2. Run "mkdir folder ; touch a b folder/b c d".
2.3. Close Dolphin's terminal (F4).
3. In the current folder, select the four empty files (a, b, c, d) and copy them \
(Ctrl+C). 4. Enter the "folder" folder.
5. Paste the files (Ctrl+V).
5.1. When asked for a new name for "b", enter "b2" and hit Enter to continue.
Result:
Items "a", "b2", "c", "d" are selected
Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=233335">233335</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(11e03d0)</span></li>
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(c27550a)</span></li>
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(6e3a767)</span></li>
<li>dolphin/src/panels/places/placespanel.cpp <span style="color: \
grey">(61c15a7)</span></li>
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(a2fe9f6)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(941083f)</span></li>
<li>dolphin/src/views/draganddrophelper.h <span style="color: \
grey">(ac16f7c)</span></li>
<li>dolphin/src/views/draganddrophelper.cpp <span style="color: \
grey">(f81d4d0)</span></li>
<li>lib/konq/konq_operations.h <span style="color: grey">(b82feb4)</span></li>
<li>lib/konq/konq_operations.cpp <span style="color: grey">(e0f1ade)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107351/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic