[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Wrong icons selected after pasting files and renaming them (because there exists
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2013-01-08 22:18:46
Message-ID: 20130108221846.23104.99196 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107351/
-----------------------------------------------------------
(Updated Jan. 8, 2013, 10:18 p.m.)
Review request for Dolphin, David Faure and Frank Reininghaus.
Changes
-------
Fixed all mentioned issues ;)
Description
-------
Bug 233335 - Wrong icons selected after pasting files and renaming them (because \
there exists items with it's names)
Dolphin 2.1 selects the existing items instead of the newly pasted + renamed items.
This addresses bug 233335.
http://bugs.kde.org/show_bug.cgi?id=233335
Diffs (updated)
-----
dolphin/src/dolphinmainwindow.cpp 11e03d0
dolphin/src/dolphinviewcontainer.cpp 26a6803
dolphin/src/panels/folders/folderspanel.cpp 6e3a767
dolphin/src/panels/places/placespanel.cpp 61c15a7
dolphin/src/views/dolphinview.h a2fe9f6
dolphin/src/views/dolphinview.cpp f0fad19
dolphin/src/views/draganddrophelper.h ac16f7c
dolphin/src/views/draganddrophelper.cpp f81d4d0
lib/konq/konq_operations.h b82feb4
lib/konq/konq_operations.cpp e0f1ade
Diff: http://git.reviewboard.kde.org/r/107351/diff/
Testing
-------
1. Open a test folder with Dolphin.
2. Create the test files:
2.1. Open Dolphin's terminal (F4).
2.2. Run "mkdir folder ; touch a b folder/b c d".
2.3. Close Dolphin's terminal (F4).
3. In the current folder, select the four empty files (a, b, c, d) and copy them \
(Ctrl+C). 4. Enter the "folder" folder.
5. Paste the files (Ctrl+V).
5.1. When asked for a new name for "b", enter "b2" and hit Enter to continue.
Result:
Items "a", "b2", "c", "d" are selected
Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)
Thanks,
Emmanuel Pescosta
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107351/">http://git.reviewboard.kde.org/r/107351/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, David Faure and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2013, 10:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed all mentioned issues ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug 233335 - Wrong icons selected after pasting files and renaming them \
(because there exists items with it's names)
Dolphin 2.1 selects the existing items instead of the newly pasted + renamed \
items.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Open a test folder with Dolphin. 2. Create the test files:
2.1. Open Dolphin's terminal (F4).
2.2. Run "mkdir folder ; touch a b folder/b c d".
2.3. Close Dolphin's terminal (F4).
3. In the current folder, select the four empty files (a, b, c, d) and copy them \
(Ctrl+C). 4. Enter the "folder" folder.
5. Paste the files (Ctrl+V).
5.1. When asked for a new name for "b", enter "b2" and hit Enter to continue.
Result:
Items "a", "b2", "c", "d" are selected
Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=233335">233335</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(11e03d0)</span></li>
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(26a6803)</span></li>
<li>dolphin/src/panels/folders/folderspanel.cpp <span style="color: \
grey">(6e3a767)</span></li>
<li>dolphin/src/panels/places/placespanel.cpp <span style="color: \
grey">(61c15a7)</span></li>
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(a2fe9f6)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(f0fad19)</span></li>
<li>dolphin/src/views/draganddrophelper.h <span style="color: \
grey">(ac16f7c)</span></li>
<li>dolphin/src/views/draganddrophelper.cpp <span style="color: \
grey">(f81d4d0)</span></li>
<li>lib/konq/konq_operations.h <span style="color: grey">(b82feb4)</span></li>
<li>lib/konq/konq_operations.cpp <span style="color: grey">(e0f1ade)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107351/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic