This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107351/ |
First of all, happy new year and sorry for the late response, real life kept me quite busy around Christmas and New Year. I'm fine with the Dolphin part of the change. About the issue concerning "Why have two methods instead of one?" raised by David: Sounds reasonable, one method is really sufficient, I think. About the possible performance problem mentioned by David: I hadn't thought about that earlier. I will most likely not create a performance problem in Dolphin, given that the slot connected to urlPasted(KUrl) doesn't do anything expensive, but as soon as the signal is there, other apps might consider using it as well, and we don't know what they will do in slots connected to that signal. So it might indeed be worth looking into the possibility of emitting the signal for a bunch of URLs at once, if that is doable. Thanks again for your awesome work. I know that may be a lot more work that one might have expected at first sight, but I'm sure that our users will greatly appreciate the result once it's finished.
- Frank
On December 13th, 2012, 11:42 p.m., Emmanuel Pescosta wrote:
Review request for Dolphin, David Faure and Frank Reininghaus.
By Emmanuel Pescosta.
Updated Dec. 13, 2012, 11:42 p.m. Description
Testing
Bugs:
233335
Diffs
|