This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107351/

First of a=
ll, happy new year and sorry for the late response, real life kept me quite=
 busy around Christmas and New Year.

I'm fine with the Dolphin part of the change. About the issue concernin=
g "Why have two methods instead of one?" raised by David: Sounds =
reasonable, one method is really sufficient, I think.

About the possible performance problem mentioned by David: I hadn't tho=
ught about that earlier. I will most likely not create a performance proble=
m in Dolphin, given that the slot connected to urlPasted(KUrl) doesn't =
do anything expensive, but as soon as the signal is there, other apps might=
 consider using it as well, and we don't know what they will do in slot=
s connected to that signal. So it might indeed be worth looking into the po=
ssibility of emitting the signal for a bunch of URLs at once, if that is do=
able.

Thanks again for your awesome work. I know that may be a lot more work that=
 one might have expected at first sight, but I'm sure that our users wi=
ll greatly appreciate the result once it's finished.

- Frank

On December 13th, 2012, 11:42 p.m., Emmanuel Pescosta wrote:

Review request for Dolphin, David Faure and Frank Reininghaus.

By Emmanuel Pescosta.

Updated Dec. 13, 2012, 11:42 p.m.

Descripti= on

Bug 233335 - Wrong icons selected after pasting files and re=
naming them (because there exists items with it's names)

Dolphin 2.1 selects the existing items instead of the newly pasted + rename=
d items.

Testing <= /h1>

1. Open a test folder with Dolphin.
2. Create the test files:
    2.1. Open Dolphin=E2=80=99s terminal (F4).
    2.2. Run =E2=80=9Cmkdir folder ; touch a b folder/b c d=E2=80=9D.
    2.3. Close Dolphin=E2=80=99s terminal (F4).
3. In the current folder, select the four empty files (a, b, c, d) and copy=
 them (Ctrl+C).
4. Enter the =E2=80=9Cfolder=E2=80=9D folder.
5. Paste the files (Ctrl+V).
    5.1. When asked for a new name for =E2=80=9Cb=E2=80=9D, enter =E2=80=9C=
b2=E2=80=9D and hit Enter to continue.

Result:
Items =E2=80=9Ca=E2=80=9D, =E2=80=9Cb2=E2=80=9D, =E2=80=9Cc=E2=80=9D, =E2=
=80=9Cd=E2=80=9D are selected

Btw. Thanks to Adri=C3=A1n Chaves Fern=C3=A1ndez for the easy way to test t=
his bug ;)

Bugs: 233335

Diffs=

dolphin/src/dolphinmainwindow.cpp (11e03d0= )
dolphin/src/dolphinviewcontainer.cpp (c275= 50a)
dolphin/src/panels/folders/folderspanel.cpp = (61c15a7)
dolphin/src/views/dolphinview.h (a2fe9f6)<= /span>
dolphin/src/views/dolphinview.cpp (941083f= )
dolphin/src/views/draganddrophelper.h (ac1= 6f7c)
dolphin/src/views/draganddrophelper.cpp (f= 81d4d0)
lib/konq/konq_operations.h (b82feb4)
lib/konq/konq_operations.cpp (e0f1ade)

View Diff