[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Use the product as text for pluggable/removable devices.
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2012-10-02 19:28:19
Message-ID: 20121002192819.25380.44611 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 1, 2012, 1:06 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! I'm looking forward to seeing meaningful device n=
ames in the Places Panel in the future :-)
> > =
> > Looks good, but I have a few little comments, see below.
Finally we will implement this in the libsolid udevbackend, so we can conti=
nue using description for all cases.
This was suggested by ervin (former libsolid and kplacesview maintainer) an=
d it makes more sense.
closing the review !
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106639/#review19686
-----------------------------------------------------------
On Sept. 29, 2012, 8:57 p.m., Alex Fiestas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106639/
> -----------------------------------------------------------
> =
> (Updated Sept. 29, 2012, 8:57 p.m.)
> =
> =
> Review request for Dolphin.
> =
> =
> Description
> -------
> =
> Use product instead of description for pluggable/removable devices.
> =
> =
> Diffs
> -----
> =
> dolphin/src/panels/places/placesitem.cpp f72f639 =
> =
> Diff: http://git.reviewboard.kde.org/r/106639/diff/
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> after
> http://git.reviewboard.kde.org/r/106639/s/747/
> before
> http://git.reviewboard.kde.org/r/106639/s/748/
> =
> =
> Thanks,
> =
> Alex Fiestas
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106639/">http://git.reviewboard.kde.org/r/106639/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 1st, 2012, 1:06 p.m., <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for the patch! I'm looking forward to seeing meaningful \
device names in the Places Panel in the future :-)
Looks good, but I have a few little comments, see below.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Finally we will \
implement this in the libsolid udevbackend, so we can continue using description for \
all cases.
This was suggested by ervin (former libsolid and kplacesview maintainer) and it makes \
more sense.
closing the review !</pre>
<br />
<p>- Alex</p>
<br />
<p>On September 29th, 2012, 8:57 p.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2012, 8:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use product instead of description for pluggable/removable \
devices.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/panels/places/placesitem.cpp <span style="color: \
grey">(f72f639)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106639/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106639/s/747/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/29/product2_400x100.png" \
style="border: 1px black solid;" alt="after" /></a>
<a href="http://git.reviewboard.kde.org/r/106639/s/748/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/29/product1_400x100.png" \
style="border: 1px black solid;" alt="before" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic