From kfm-devel Tue Oct 02 19:28:19 2012 From: "Alex Fiestas" Date: Tue, 02 Oct 2012 19:28:19 +0000 To: kfm-devel Subject: Re: Review Request: Use the product as text for pluggable/removable devices. Message-Id: <20121002192819.25380.44611 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=134921382714095 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6941253975619738133==" --===============6941253975619738133== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Oct. 1, 2012, 1:06 p.m., Frank Reininghaus wrote: > > Thanks for the patch! I'm looking forward to seeing meaningful device n= ames in the Places Panel in the future :-) > > = > > Looks good, but I have a few little comments, see below. Finally we will implement this in the libsolid udevbackend, so we can conti= nue using description for all cases. This was suggested by ervin (former libsolid and kplacesview maintainer) an= d it makes more sense. closing the review ! - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106639/#review19686 ----------------------------------------------------------- On Sept. 29, 2012, 8:57 p.m., Alex Fiestas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106639/ > ----------------------------------------------------------- > = > (Updated Sept. 29, 2012, 8:57 p.m.) > = > = > Review request for Dolphin. > = > = > Description > ------- > = > Use product instead of description for pluggable/removable devices. > = > = > Diffs > ----- > = > dolphin/src/panels/places/placesitem.cpp f72f639 = > = > Diff: http://git.reviewboard.kde.org/r/106639/diff/ > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > after > http://git.reviewboard.kde.org/r/106639/s/747/ > before > http://git.reviewboard.kde.org/r/106639/s/748/ > = > = > Thanks, > = > Alex Fiestas > = > --===============6941253975619738133== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106639/

On October 1st, 2012, 1:06 p.m., Frank Rein= inghaus wrote:

Thanks fo=
r the patch! I'm looking forward to seeing meaningful device names in t=
he Places Panel in the future :-)

Looks good, but I have a few little comments, see below.

Finally we =
will implement this in the libsolid udevbackend, so we can continue using d=
escription for all cases.

This was suggested by ervin (former libsolid and kplacesview maintainer) an=
d it makes more sense.

closing the review !

- Alex

On September 29th, 2012, 8:57 p.m., Alex Fiestas wrote:

Review request for Dolphin.

By Alex Fiestas.

Updated Sept. 29, 2012, 8:57 p.m.

Descripti= on

Use product instead of description for pluggable/removable d=
evices.

Diffs=

dolphin/src/panels/places/placesitem.cpp (= f72f639)

View Diff

Screensho= ts

--===============6941253975619738133==--