[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Use the product as text for pluggable/removable devices.
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2012-10-01 13:05:59
Message-ID: 20121001130559.21610.35123 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106639/#review19686
-----------------------------------------------------------
Thanks for the patch! I'm looking forward to seeing meaningful device names=
in the Places Panel in the future :-)
Looks good, but I have a few little comments, see below.
dolphin/src/panels/places/placesitem.cpp
<http://git.reviewboard.kde.org/r/106639/#comment15661>
We put the '*' before the space in Dolphin code.
=
Moreover, I think you could move this part of your patch a bit further =
down, between 'setUdi(udi)' and the second part, right? Better keep things=
that belong together close to each other.
dolphin/src/panels/places/placesitem.cpp
<http://git.reviewboard.kde.org/r/106639/#comment15662>
To make the overall structure of the code clearer, I would add an 'else=
' branch here and move the line 'setText(m_device.description())' from furt=
her up into that branch.
- Frank Reininghaus
On Sept. 29, 2012, 8:57 p.m., Alex Fiestas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106639/
> -----------------------------------------------------------
> =
> (Updated Sept. 29, 2012, 8:57 p.m.)
> =
> =
> Review request for Dolphin.
> =
> =
> Description
> -------
> =
> Use product instead of description for pluggable/removable devices.
> =
> =
> Diffs
> -----
> =
> dolphin/src/panels/places/placesitem.cpp f72f639 =
> =
> Diff: http://git.reviewboard.kde.org/r/106639/diff/
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> after
> http://git.reviewboard.kde.org/r/106639/s/747/
> before
> http://git.reviewboard.kde.org/r/106639/s/748/
> =
> =
> Thanks,
> =
> Alex Fiestas
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106639/">http://git.reviewboard.kde.org/r/106639/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch! \
I'm looking forward to seeing meaningful device names in the Places Panel in the \
future :-)
Looks good, but I have a few little comments, see below.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106639/diff/1/?file=87792#file87792line253" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/panels/places/placesitem.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PlacesItem::initializeDevice(const QString& udi)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">253</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Solid</span><span class="o">::</span><span class="n">StorageDrive</span> \
<span class="o">*</span><span class="n">drive</span> <span class="o">=</span> <span \
class="mi">0</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We put the \
'*' before the space in Dolphin code.
Moreover, I think you could move this part of your patch a bit further down, between \
'setUdi(udi)' and the second part, right? Better keep things that belong \
together close to each other.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106639/diff/1/?file=87792#file87792line269" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/panels/places/placesitem.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PlacesItem::initializeDevice(const QString& udi)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">269</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">drive</span> <span \
class="o">&&</span> <span class="p">(</span><span class="n">drive</span><span \
class="o">-></span><span class="n">isHotpluggable</span><span class="p">()</span> \
<span class="o">||</span> <span class="n">drive</span><span \
class="o">-></span><span class="n">isRemovable</span><span class="p">()))</span> \
<span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To make the \
overall structure of the code clearer, I would add an 'else' branch here and \
move the line 'setText(m_device.description())' from further up into that \
branch.</pre> </div>
<br />
<p>- Frank</p>
<br />
<p>On September 29th, 2012, 8:57 p.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2012, 8:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use product instead of description for pluggable/removable \
devices.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/panels/places/placesitem.cpp <span style="color: \
grey">(f72f639)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106639/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106639/s/747/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/29/product2_400x100.png" \
style="border: 1px black solid;" alt="after" /></a>
<a href="http://git.reviewboard.kde.org/r/106639/s/748/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/29/product1_400x100.png" \
style="border: 1px black solid;" alt="before" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic