This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106639/

On October 1st, 2012, 1:06 p.m., Frank Reininghaus wrote:

Thanks for the patch! I'm looking forward to seeing meaningful device names in the Places Panel in the future :-)

Looks good, but I have a few little comments, see below.
Finally we will implement this in the libsolid udevbackend, so we can continue using description for all cases.

This was suggested by ervin (former libsolid and kplacesview maintainer) and it makes more sense.

closing the review !

- Alex


On September 29th, 2012, 8:57 p.m., Alex Fiestas wrote:

Review request for Dolphin.
By Alex Fiestas.

Updated Sept. 29, 2012, 8:57 p.m.

Description

Use product instead of description for pluggable/removable devices.

Diffs

  • dolphin/src/panels/places/placesitem.cpp (f72f639)

View Diff

Screenshots

after before