'Re: Review Request: sanitize applyPatch()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: Review Request: sanitize applyPatch()
From:       "Ralf Habacker" <ralf.habacker () freenet ! de>
Date:       2011-01-18 21:00:36
Message-ID: 20110118210036.8327.59242 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6347/#review9653
-----------------------------------------------------------

Ship it!

looks good

- Ralf

On Jan. 16, 2011, 11:34 p.m., Wolfgang Rohdewald wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6347/
> -----------------------------------------------------------
> =

> (Updated Jan. 16, 2011, 11:34 p.m.)
> =

> =

> Review request for kde-windows.
> =

> =

> Summary
> -------
> =

>     *Source.applyPatch: The overriding methods in GitSource, HgSource,
>     SvnSource should have the same number of arguments as in the
>     base class. This does not fix a bug, it is just cleaner and makes
>     pylint happy - and it might prevent future bugs.
>     =

>     MultiSource.applyPatch() cannot possibly work. So raise an
>     exception explaining the situation and comment the wrong code.
> =

> =

> Diffs
> -----
> =

>   /trunk/kdesupport/emerge/bin/Source/GitSource.py 1214807 =

>   /trunk/kdesupport/emerge/bin/Source/HgSource.py 1214807 =

>   /trunk/kdesupport/emerge/bin/Source/MultiSource.py 1214807 =

>   /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1214807 =

>   /trunk/kdesupport/emerge/bin/Source/SvnSource.py 1214807 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6347/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Wolfgang
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6347/">http://svn.reviewboard.kde.org/r/6347/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good</pre>  <br />

<p>- Ralf</p>

<br />
<p>On January 16th, 2011, 11:34 p.m., Wolfgang Rohdewald wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>

<p style="color: grey;"><i>Updated Jan. 16, 2011, 11:34 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    *Source.applyPatch: The overriding methods in GitSource, HgSource,  \
SvnSource should have the same number of arguments as in the  base class. This does \
not fix a bug, it is just cleaner and makes  pylint happy - and it might prevent \
future bugs.  
    MultiSource.applyPatch() cannot possibly work. So raise an
    exception explaining the situation and comment the wrong code.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/kdesupport/emerge/bin/Source/GitSource.py <span style="color: \
grey">(1214807)</span></li>

 <li>/trunk/kdesupport/emerge/bin/Source/HgSource.py <span style="color: \
grey">(1214807)</span></li>

 <li>/trunk/kdesupport/emerge/bin/Source/MultiSource.py <span style="color: \
grey">(1214807)</span></li>

 <li>/trunk/kdesupport/emerge/bin/Source/SourceBase.py <span style="color: \
grey">(1214807)</span></li>

 <li>/trunk/kdesupport/emerge/bin/Source/SvnSource.py <span style="color: \
grey">(1214807)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6347/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[prev in list] [next in list] [prev in thread] [next in thread] 