From kde-windows Tue Jan 18 21:00:36 2011 From: "Ralf Habacker" Date: Tue, 18 Jan 2011 21:00:36 +0000 To: kde-windows Subject: Re: Review Request: sanitize applyPatch() Message-Id: <20110118210036.8327.59242 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-windows&m=129538451429582 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2003886574==" --===============2003886574== Content-Type: multipart/alternative; boundary="===============1352738113767519807==" --===============1352738113767519807== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6347/#review9653 ----------------------------------------------------------- Ship it! looks good - Ralf On Jan. 16, 2011, 11:34 p.m., Wolfgang Rohdewald wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6347/ > ----------------------------------------------------------- > = > (Updated Jan. 16, 2011, 11:34 p.m.) > = > = > Review request for kde-windows. > = > = > Summary > ------- > = > *Source.applyPatch: The overriding methods in GitSource, HgSource, > SvnSource should have the same number of arguments as in the > base class. This does not fix a bug, it is just cleaner and makes > pylint happy - and it might prevent future bugs. > = > MultiSource.applyPatch() cannot possibly work. So raise an > exception explaining the situation and comment the wrong code. > = > = > Diffs > ----- > = > /trunk/kdesupport/emerge/bin/Source/GitSource.py 1214807 = > /trunk/kdesupport/emerge/bin/Source/HgSource.py 1214807 = > /trunk/kdesupport/emerge/bin/Source/MultiSource.py 1214807 = > /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1214807 = > /trunk/kdesupport/emerge/bin/Source/SvnSource.py 1214807 = > = > Diff: http://svn.reviewboard.kde.org/r/6347/diff > = > = > Testing > ------- > = > = > Thanks, > = > Wolfgang > = > --===============1352738113767519807== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6347/

Ship it!

looks good=

- Ralf

On January 16th, 2011, 11:34 p.m., Wolfgang Rohdewald wrote:

Review request for kde-windows.

By Wolfgang Rohdewald.

Updated Jan. 16, 2011, 11:34 p.m.

Descripti= on

    *Source.applyPatch: The overriding methods in GitSource,=
 HgSource,
    SvnSource should have the same number of arguments as in the
    base class. This does not fix a bug, it is just cleaner and makes
    pylint happy - and it might prevent future bugs.
    =

    MultiSource.applyPatch() cannot possibly work. So raise an
    exception explaining the situation and comment the wrong code.

Diffs=

/trunk/kdesupport/emerge/bin/Source/GitSource.py (1214807)
/trunk/kdesupport/emerge/bin/Source/HgSource.py (1214807)
/trunk/kdesupport/emerge/bin/Source/MultiSource.py (1214807)
/trunk/kdesupport/emerge/bin/Source/SourceBase.py (1214807)
/trunk/kdesupport/emerge/bin/Source/SvnSource.py (1214807)

View Diff

--===============1352738113767519807==-- --===============2003886574== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows --===============2003886574==--