[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-windows
Subject: Re: Review Request: EmergeBase: Ensure that an object of this type
From: "Ralf Habacker" <ralf.habacker () freenet ! de>
Date: 2011-01-18 21:03:56
Message-ID: 20110118210356.8793.72232 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6345/#review9654
-----------------------------------------------------------
Ship it!
looks good
- Ralf
On Jan. 16, 2011, 11:28 p.m., Wolfgang Rohdewald wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6345/
> -----------------------------------------------------------
> =
> (Updated Jan. 16, 2011, 11:28 p.m.)
> =
> =
> Review request for kde-windows.
> =
> =
> Summary
> -------
> =
> EmergeBase.__init__: if the object does not yet have attribute
> buildSystemType, set it to None. This makes referencing this
> attribute easier because "if hasattr()" is no longer needed. And
> it makes pylint happy.
> The same thing has already been done with subinfo, r1214441, which
> resulted in no complaints or problems
> =
> =
> Diffs
> -----
> =
> /trunk/kdesupport/emerge/bin/EmergeBase.py 1214807 =
> /trunk/kdesupport/emerge/bin/Package/PackageBase.py 1214807 =
> /trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py 1214=
807 =
> /trunk/kdesupport/emerge/bin/Source/ArchiveSource.py 1214807 =
> /trunk/kdesupport/emerge/bin/Source/FileSource.py 1214807 =
> /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1214807 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6345/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Wolfgang
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6345/">http://svn.reviewboard.kde.org/r/6345/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good</pre> <br />
<p>- Ralf</p>
<br />
<p>On January 16th, 2011, 11:28 p.m., Wolfgang Rohdewald wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-windows.</div>
<div>By Wolfgang Rohdewald.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2011, 11:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> EmergeBase.__init__: if the object does not yet have attribute \
buildSystemType, set it to None. This makes referencing this attribute easier \
because "if hasattr()" is no longer needed. And it makes pylint happy.
The same thing has already been done with subinfo, r1214441, which
resulted in no complaints or problems
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdesupport/emerge/bin/EmergeBase.py <span style="color: \
grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Package/PackageBase.py <span style="color: \
grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py <span \
style="color: grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/ArchiveSource.py <span style="color: \
grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/FileSource.py <span style="color: \
grey">(1214807)</span></li>
<li>/trunk/kdesupport/emerge/bin/Source/SourceBase.py <span style="color: \
grey">(1214807)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6345/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic