This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6347/

Ship it!

looks good

- Ralf

On January 16th, 2011, 11:34 p.m., Wolfgang Rohdewald wrote:

Review request for kde-windows.

By Wolfgang Rohdewald.

Updated Jan. 16, 2011, 11:34 p.m.

Description

    *Source.applyPatch: The overriding methods in GitSource, HgSource,
    SvnSource should have the same number of arguments as in the
    base class. This does not fix a bug, it is just cleaner and makes
    pylint happy - and it might prevent future bugs.
    
    MultiSource.applyPatch() cannot possibly work. So raise an
    exception explaining the situation and comment the wrong code.

Diffs

/trunk/kdesupport/emerge/bin/Source/GitSource.py (1214807)
/trunk/kdesupport/emerge/bin/Source/HgSource.py (1214807)
/trunk/kdesupport/emerge/bin/Source/MultiSource.py (1214807)
/trunk/kdesupport/emerge/bin/Source/SourceBase.py (1214807)
/trunk/kdesupport/emerge/bin/Source/SvnSource.py (1214807)

View Diff