'Re: [KDE Usability] Review Request 107016: Make Find a toggle action'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: [KDE Usability] Review Request 107016: Make Find a toggle action
From:       Àlex_Fiestas <afiestas () kde ! org>
Date:       2015-07-11 21:48:38
Message-ID: 20150711214838.16549.63675 () mimi ! kde ! org
[Download RAW message or body]

--===============2888224874519056112==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107016/
-----------------------------------------------------------

(Updated July 11, 2015, 11:48 p.m.)

Review request for Dolphin, KDE Usability and Frank Osterfeld.

Changes
-------

Adding usability group. Could we get a screenshot? That will help the usability team \
to figure out what's best.

Repository: kde-baseapps

Description
-------

I was working in the placesview when I noticed that the Find is not a toggle button. \
Pushing many times the Find button resulted in "nothing" and I expected it to \
"disable" the search mode, as it happens with Split, or Preview.

The patch is pretty straight forward.

Diffs
-----

  dolphin/src/dolphinmainwindow.h 7da5801 
  dolphin/src/dolphinmainwindow.cpp b4a25a7 

Diff: https://git.reviewboard.kde.org/r/107016/diff/

Testing
-------

Thanks,

Àlex Fiestas

--===============2888224874519056112==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/107016/">https://git.reviewboard.kde.org/r/107016/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin, KDE Usability and Frank Osterfeld.</div>
<div>By Àlex Fiestas.</div>

<p style="color: grey;"><i>Updated July 11, 2015, 11:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding usability group. Could we get a screenshot? That will help the \
usability team to figure out what&#39;s best.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was working in the placesview when I noticed that the Find is not a \
toggle button. Pushing many times the Find button resulted in &quot;nothing&quot; and \
I expected it to &quot;disable&quot; the search mode, as it happens with Split, or \
Preview.

The patch is pretty straight forward.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7da5801)</span></li>

 <li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(b4a25a7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/107016/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2888224874519056112==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability

[prev in list] [next in list] [prev in thread] [next in thread] 