'Re: [KDE Usability] Review Request 124234: Add option to always show all system tray icons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: [KDE Usability] Review Request 124234: Add option to always show all system tray icons
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-07-09 17:58:40
Message-ID: 20150709175840.16549.78845 () mimi ! kde ! org
[Download RAW message or body]

--===============0911010789370939740==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124234/
-----------------------------------------------------------

(Updated July 9, 2015, 5:58 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and KDE Usability.

Changes
-------

Submitted with commit 1b7e63e80b9528c91ac82afeeef9e99979f620d2 by Kai Uwe Broulik to \
branch master.

Bugs: 349812
    https://bugs.kde.org/show_bug.cgi?id=349812

Repository: plasma-workspace

Description
-------

This adds an option to always show all system tray icons and never collapse them into \
the popup. I've seen a couple of people already requesting this.

Diffs
-----

  applets/systemtray/package/contents/config/main.xml 8e8996c 
  applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 
  applets/systemtray/package/contents/ui/TaskDelegate.qml 221c6e7 
  applets/systemtray/package/contents/ui/main.qml e794d1c 
  applets/systemtray/plugin/host.h bd9728b 
  applets/systemtray/plugin/host.cpp 5c897fa 

Diff: https://git.reviewboard.kde.org/r/124234/diff/

Testing
-------

Enabled and disabled the option and tray icons along with the arrow came and went, \
started music player and media controller properly appeared and disappeared, started \
and quit KMail and its icon properla appeared and disappeared with both options.

File Attachments
----------------

Settings dialog (disabled)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png
 Settings dialog (enabled)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png
 System Tray (disabled)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png
 System Tray (enabled)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png
 Better dialog layout
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png
 Dim System Tray
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png

Thanks,

Kai Uwe Broulik

--===============0911010789370939740==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124234/">https://git.reviewboard.kde.org/r/124234/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated July 9, 2015, 5:58 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1b7e63e80b9528c91ac82afeeef9e99979f620d2 by Kai \
Uwe Broulik to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=349812">349812</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds an option to always show all system tray \
icons and never collapse them into the popup. I've seen a couple of people already \
requesting this.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Enabled and disabled the option and tray icons along \
with the arrow came and went, started music player and media controller properly \
appeared and disappeared, started and quit KMail and its icon properla appeared and \
disappeared with both options.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemtray/package/contents/config/main.xml <span style="color: \
grey">(8e8996c)</span></li>

 <li>applets/systemtray/package/contents/ui/ConfigEntries.qml <span style="color: \
grey">(8b6ec28)</span></li>

 <li>applets/systemtray/package/contents/ui/TaskDelegate.qml <span style="color: \
grey">(221c6e7)</span></li>

 <li>applets/systemtray/package/contents/ui/main.qml <span style="color: \
grey">(e794d1c)</span></li>

 <li>applets/systemtray/plugin/host.h <span style="color: grey">(bd9728b)</span></li>

 <li>applets/systemtray/plugin/host.cpp <span style="color: \
grey">(5c897fa)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124234/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png">Settings \
dialog (disabled)</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png">Settings \
dialog (enabled)</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png">System \
Tray (disabled)</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png">System \
Tray (enabled)</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png">Better \
dialog layout</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png">Dim \
System Tray</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0911010789370939740==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability

[prev in list] [next in list] [prev in thread] [next in thread] 