--===============0968224414484538253== Content-Type: multipart/alternative; boundary="===============2888224874519056112==" --===============2888224874519056112== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107016/ ----------------------------------------------------------- (Updated July 11, 2015, 11:48 p.m.) Review request for Dolphin, KDE Usability and Frank Osterfeld. Changes ------- Adding usability group. Could we get a screenshot? That will help the usability team to figure out what's best. Repository: kde-baseapps Description ------- I was working in the placesview when I noticed that the Find is not a toggle button. Pushing many times the Find button resulted in "nothing" and I expected it to "disable" the search mode, as it happens with Split, or Preview. The patch is pretty straight forward. Diffs ----- dolphin/src/dolphinmainwindow.h 7da5801 dolphin/src/dolphinmainwindow.cpp b4a25a7 Diff: https://git.reviewboard.kde.org/r/107016/diff/ Testing ------- Thanks, Àlex Fiestas --===============2888224874519056112== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107016/

Review request for Dolphin, KDE Usability and Frank Osterfeld.

By Àlex Fiestas.

Updated July 11, 2015, 11:48 p.m.

Changes

Adding usability group. Could we get a screenshot? That will help the usability team to figure out what's best.

Repository: kde-baseapps

Description

I was working in the placesview when I noticed that the Find is not a toggle button. Pushing many times the Find button resulted in "nothing" and I expected it to "disable" the search mode, as it happens with Split, or Preview.

The patch is pretty straight forward.

Diffs

dolphin/src/dolphinmainwindow.h (7da5801)
dolphin/src/dolphinmainwindow.cpp (b4a25a7)

View Diff

--===============2888224874519056112==-- --===============0968224414484538253== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2RlLXVzYWJp bGl0eSBtYWlsaW5nIGxpc3QKa2RlLXVzYWJpbGl0eUBrZGUub3JnCmh0dHBzOi8vbWFpbC5rZGUu b3JnL21haWxtYW4vbGlzdGluZm8va2RlLXVzYWJpbGl0eQo= --===============0968224414484538253==--