'Re: [KDE Usability] Review Request 110326: Places Panel: Only show devices which do not exist in the'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: [KDE Usability] Review Request 110326: Places Panel: Only show devices which do not exist in the
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2015-07-11 21:48:49
Message-ID: 20150711214849.16549.55958 () mimi ! kde ! org
[Download RAW message or body]

--===============3132155990355730577==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110326/
-----------------------------------------------------------

(Updated July 11, 2015, 11:48 p.m.)

Review request for Dolphin, KDE Usability, Àlex Fiestas, and Frank Reininghaus.

Changes
-------

Adding usability group. Could we get a screenshot? That will help the usability team \
to figure out what's best.

Repository: kde-baseapps

Description
-------

    Places Panel: Only show devices which do not exist in the Places

    No point showing them twice.

Diffs
-----

  dolphin/src/panels/places/placesitemmodel.cpp 1acbb57 

Diff: https://git.reviewboard.kde.org/r/110326/diff/

Testing
-------

works!

Thanks,

Vishesh Handa

--===============3132155990355730577==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/110326/">https://git.reviewboard.kde.org/r/110326/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin, KDE Usability, Àlex Fiestas, and Frank \
Reininghaus.</div> <div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated July 11, 2015, 11:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding usability group. Could we get a screenshot? That will help the \
usability team to figure out what&#39;s best.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Places Panel: Only show devices which do not exist in the Places  
    No point showing them twice.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works!</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/panels/places/placesitemmodel.cpp <span style="color: \
grey">(1acbb57)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/110326/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3132155990355730577==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability

[prev in list] [next in list] [prev in thread] [next in thread] 