[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-10-31 22:56:44
Message-ID: 20171031225644.45297.3F2377E18A4F0666 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  > KIconLoader does, but even Qt's own ones QSvgIconEngine and QPixmapIconEngine \
don't currently.  
  I did fix QPixmapIcon and QSvgIconEngine,
  
  This should mean we can change QIcon::fromTheme to check isNull() which will then \
implicitly solve this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5109

To: broulik, #plasma, hein
Cc: rkflx, smartins, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5109" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>KIconLoader does, but even Qt&#039;s own ones \
QSvgIconEngine and QPixmapIconEngine don&#039;t currently.</p></blockquote>

<p>I did fix QPixmapIcon and QSvgIconEngine,</p>

<p>This should mean we can change QIcon::fromTheme to check isNull() which will then \
implicitly solve this.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5109" \
rel="noreferrer">https://phabricator.kde.org/D5109</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>rkflx, \
smartins, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]