[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8585: Preserve the order in dbus menu when doing action reusing.
From:       Xuetian Weng <noreply () phabricator ! kde ! org>
Date:       2017-10-31 23:40:26
Message-ID: differential-rev-PHID-DREV-sthclmj3txhti5qcrrhi-req () phabricator ! kde ! org
[Download RAW message or body]

xuetianweng created this revision.
xuetianweng added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Right now, new Action always appends to the list, but application may
  want to add new action in the middle of the menu. This breaks such
  application with dynamic menu entries. This change tries to keep the
  order of actions same as the order in dbus request.

TEST PLAN
  Manually tested the brokened menu in certain applications.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.11

REVISION DETAIL
  https://phabricator.kde.org/D8585

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: xuetianweng, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">xuetianweng created this revision.<br />xuetianweng added \
reviewers: Plasma, davidedmundson.<br />Restricted Application added a project: \
Plasma. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8585" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Right \
now, new Action always appends to the list, but application may<br /> want to add new \
action in the middle of the menu. This breaks such<br /> application with dynamic \
menu entries. This change tries to keep the<br /> order of actions same as the order \
in dbus request.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Manually \
tested the brokened menu in certain applications.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Plasma/5.11</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8585" \
rel="noreferrer">https://phabricator.kde.org/D8585</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>libdbusmenuqt/dbusmenuimporter.cpp</div></div></div><br \
/><div><strong>To: </strong>xuetianweng, Plasma, davidedmundson<br /><strong>Cc: \
</strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]