--87fa0ad8dc6a46e6b18c59f13f781c65
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

davidedmundson added a comment.


  > KIconLoader does, but even Qt's own ones QSvgIconEngine and QPixmapIconEngine don't currently.
  
  I did fix QPixmapIcon and QSvgIconEngine,
  
  This should mean we can change QIcon::fromTheme to check isNull() which will then implicitly solve this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5109

To: broulik, #plasma, hein
Cc: rkflx, smartins, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--87fa0ad8dc6a46e6b18c59f13f781c65
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">davidedmundson added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D5109" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><blockquote style=3D"border-left: 3px solid #a=
7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4=
px 12px; background-color: #f8f9fc;"><p>KIconLoader does, but even Qt&#039;=
s own ones QSvgIconEngine and QPixmapIconEngine don&#039;t currently.</p></=
blockquote>

<p>I did fix QPixmapIcon and QSvgIconEngine,</p>

<p>This should mean we can change QIcon::fromTheme to check isNull() which =
will then implicitly solve this.</p></div></div><br /><div><strong>REPOSITO=
RY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><stron=
g>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde.org/D5109=
" rel=3D"noreferrer">https://phabricator.kde.org/D5109</a></div></div><br /=
><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>=
rkflx, smartins, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff,=
 lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></=
div>
--87fa0ad8dc6a46e6b18c59f13f781c65--