[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found
From:       Henrik Fehlauer <noreply () phabricator ! kde ! org>
Date:       2017-10-31 22:48:20
Message-ID: 20171031224820.121791.7A905FD999F09089 () phabricator ! kde ! org
[Download RAW message or body]

rkflx added subscribers: smartins, rkflx.
rkflx added a comment.


  I keep stumbling upon this issue on bugzilla and wonder what we can do here?
  
  - Fix the issue in Qt. @smartins recently opened \
https://bugreports.qt.io/browse/QTBUG-63187, but besides triaging to `P3` not much \
has happened yet. This may need someone submitting a patch. \
                https://bugreports.qt.io/browse/QTBUG-59732 might be related.
  - Add workarounds everywhere in our projects (not very appealing):
    - Pursue this Diff.
    - Try a different approach, e.g. strip the `.svg` from the absolute path in case \
of failure and try again.  
  ---
  
  Bugzillas (lxr will probably find even more cases):
  https://bugs.kde.org/show_bug.cgi?id=371835
  https://bugs.kde.org/show_bug.cgi?id=381442
  https://bugs.kde.org/show_bug.cgi?id=315983
  https://bugs.kde.org/show_bug.cgi?id=368951
  https://bugs.kde.org/show_bug.cgi?id=365131

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5109

To: broulik, #plasma, hein
Cc: rkflx, smartins, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">rkflx added subscribers: smartins, rkflx.<br />rkflx added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5109" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I keep stumbling upon this issue on \
bugzilla and wonder what we can do here?</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Fix the issue in Qt. <a \
href="https://phabricator.kde.org/p/smartins/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@smartins</a> recently opened <a \
href="https://bugreports.qt.io/browse/QTBUG-63187" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugreports.qt.io/browse/QTBUG-63187</a>, but \
besides triaging to <tt style="background: #ebebeb; font-size: 13px;">P3</tt> not \
much has happened yet. This may need someone submitting a patch. <a \
href="https://bugreports.qt.io/browse/QTBUG-59732" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugreports.qt.io/browse/QTBUG-59732</a> \
might be related.</li> <li class="remarkup-list-item">Add workarounds everywhere in \
our projects (not very appealing):<ul class="remarkup-list"> <li \
class="remarkup-list-item">Pursue this Diff.</li> <li class="remarkup-list-item">Try \
a different approach, e.g. strip the <tt style="background: #ebebeb; font-size: \
13px;">.svg</tt> from the absolute path in case of failure and try again.</li> \
</ul></li> </ul>

<hr class="remarkup-hr" />

<p>Bugzillas (lxr will probably find even more cases):<br />
<a href="https://bugs.kde.org/show_bug.cgi?id=371835" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=371835</a><br \
/> <a href="https://bugs.kde.org/show_bug.cgi?id=381442" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=381442</a><br \
/> <a href="https://bugs.kde.org/show_bug.cgi?id=315983" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=315983</a><br \
/> <a href="https://bugs.kde.org/show_bug.cgi?id=368951" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=368951</a><br \
/> <a href="https://bugs.kde.org/show_bug.cgi?id=365131" class="remarkup-link" \
target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=365131</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5109" \
rel="noreferrer">https://phabricator.kde.org/D5109</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>rkflx, \
smartins, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]