[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D1722: Import next-gen libtaskmanager.
From:       graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date:       2016-05-31 15:50:03
Message-ID: 20160531155000.37962.34807.988BCAEF () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


graesslin added a comment.


  Totally stupid question: why import at all into plasma-workspace? We could also \
make it a standalone repository or does it depend on something else in \
plasma-workspace?

INLINE COMMENTS

> CMakeLists.txt:18-23
> +if (X11_FOUND)
> +    set(taskmanager_LIB_SRCS
> +        ${taskmanager_LIB_SRCS}
> +        xwindowtasksmodel.cpp
> +    )
> +endif()

do we want to have X11 conditional? Other areas of Plasma use X11 unconditionally.

> CMakeLists.txt:51
> +        PRIVATE
> +            ${Qt5X11Extras_LIBRARIES}
> +            KF5::IconThemes)

Qt5::X11Extras

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas


[Attachment #5 (text/html)]

<div>graesslin added a comment.</div><br /><div><div><p>Totally stupid question: why \
import at all into plasma-workspace? We could also make it a standalone repository or \
does it depend on something else in plasma-workspace?</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1722#inline-6682" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:18-23</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">if (X11_FOUND) </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">    set(taskmanager_LIB_SRCS </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        \
${taskmanager_LIB_SRCS} </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">        xwindowtasksmodel.cpp </div><div style="padding: 0 8px; margin: 0 \
4px; background: #d0ffd0;">    ) </div><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">endif() </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">do \
we want to have X11 conditional? Other areas of Plasma use X11 \
unconditionally.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D1722#inline-6683" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:51</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">        PRIVATE </div><div style="padding: 0 8px; margin: 0 \
4px; background: #d0ffd0;">            ${Qt5X11Extras_LIBRARIES} </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            \
KF5::IconThemes) </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Qt5::X11Extras</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1722" \
rel="noreferrer">https://phabricator.kde.org/D1722</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>graesslin, \
broulik, davidedmundson, plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]