graesslin added a comment.

Totally stupid question: why import at all into plasma-workspace? We could also make it a standalone repository or does it depend on something else in plasma-workspace?

INLINE COMMENTS

View InlineCMakeLists.txt:18-23

if (X11_FOUND)
    set(taskmanager_LIB_SRCS
        ${taskmanager_LIB_SRCS}
        xwindowtasksmodel.cpp
    )
endif()

do we want to have X11 conditional? Other areas of Plasma use X11 unconditionally.

View InlineCMakeLists.txt:51

        PRIVATE
            ${Qt5X11Extras_LIBRARIES}
            KF5::IconThemes)

Qt5::X11Extras

REPOSITORY

rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL

https://phabricator.kde.org/D1722

EMAIL PREFERENCES

https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas