From kde-panel-devel  Tue May 31 15:50:03 2016
From: =?utf-8?q?graesslin_=28Martin_Gr=C3=A4=C3=9Flin=29?= <noreply () phabricator ! kde ! or
Date: Tue, 31 May 2016 15:50:03 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D1722: Import next-gen libtaskmanager.
Message-Id: <20160531155000.37962.34807.988BCAEF () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=146470982109420
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============2366428056340240721=="

--===============2366428056340240721==
Content-Type: multipart/alternative; boundary="4e9b44f5a63d4ef8981a8effd2779684"

--4e9b44f5a63d4ef8981a8effd2779684
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

graesslin added a comment.


  Totally stupid question: why import at all into plasma-workspace? We could also make it a standalone repository or does it depend on something else in plasma-workspace?

INLINE COMMENTS

> CMakeLists.txt:18-23
> +if (X11_FOUND)
> +    set(taskmanager_LIB_SRCS
> +        ${taskmanager_LIB_SRCS}
> +        xwindowtasksmodel.cpp
> +    )
> +endif()

do we want to have X11 conditional? Other areas of Plasma use X11 unconditionally.

> CMakeLists.txt:51
> +        PRIVATE
> +            ${Qt5X11Extras_LIBRARIES}
> +            KF5::IconThemes)

Qt5::X11Extras

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas

--4e9b44f5a63d4ef8981a8effd2779684
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<div>graesslin=20added=20a=20comment.</div><br=20/><div><div><p>Totally=20s=
tupid=20question:=20why=20import=20at=20all=20into=20plasma-workspace?=20We=
=20could=20also=20make=20it=20a=20standalone=20repository=20or=20does=20it=
=20depend=20on=20something=20else=20in=20plasma-workspace?</p></div></div><=
br=20/><div><strong>INLINE=20COMMENTS</strong><div><div=20style=3D"margin:=
=206px=200=2012px=200;"><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20=
border-radius:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F=
7;=20border-color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=
=200=201px=200;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20backgro=
und:=20#eff2f4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=
=3D"float:=20right;=20text-decoration:=20none;"=20href=3D"https://phabricat=
or.kde.org/D1722#inline-6682"=20rel=3D"noreferrer">View=20Inline</a><span=
=20style=3D"color:=20#4b4d51;=20font-weight:=20bold;">CMakeLists.txt:18-23<=
/span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#d0ffd0;">if=20(X11_FOUND)
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20set(taskmanager_LIB_SRCS
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20${taskmanager_LIB_SRCS}
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20xwindowtasksmodel.cpp
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20)
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">endif()
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">do=20we=20want=20to=20have=20X11=20conditiona=
l?=20Other=20areas=20of=20Plasma=20use=20X11=20unconditionally.</p></div></=
div><br=20/><div=20style=3D"border:=201px=20solid=20#C7CCD9;=20border-radiu=
s:=203px;"><div=20style=3D"padding:=200;=20background:=20#F7F7F7;=20border-=
color:=20#e3e4e8;=20border-style:=20solid;=20border-width:=200=200=201px=20=
0;=20margin:=200;"><div=20style=3D"color:=20#74777d;=20background:=20#eff2f=
4;=20padding:=206px=208px;=20overflow:=20hidden;"><a=20style=3D"float:=20ri=
ght;=20text-decoration:=20none;"=20href=3D"https://phabricator.kde.org/D172=
2#inline-6683"=20rel=3D"noreferrer">View=20Inline</a><span=20style=3D"color=
:=20#4b4d51;=20font-weight:=20bold;">CMakeLists.txt:51</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#d0ffd0;">=20=20=20=20=20=20=
=20=20PRIVATE
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20=20=20=20=20${Qt5X11Extras_LIBRARIES}
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20=20=20=20=20KF5::IconThemes)
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">Qt5::X11Extras</p></div></div></div></div></d=
iv><br=20/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE=20Pla=
sma=20Workspace</div></div></div><br=20/><div><strong>REVISION=20DETAIL</st=
rong><div><a=20href=3D"https://phabricator.kde.org/D1722"=20rel=3D"noreferr=
er">https://phabricator.kde.org/D1722</a></div></div><br=20/><div><strong>E=
MAIL=20PREFERENCES</strong><div><a=20href=3D"https://phabricator.kde.org/se=
ttings/panel/emailpreferences/"=20rel=3D"noreferrer">https://phabricator.kd=
e.org/settings/panel/emailpreferences/</a></div></div><br=20/><div><strong>=
To:=20</strong>hein,=20Plasma<br=20/><strong>Cc:=20</strong>graesslin,=20br=
oulik,=20davidedmundson,=20plasma-devel,=20sebas<br=20/></div>
--4e9b44f5a63d4ef8981a8effd2779684--

--===============2366428056340240721==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl
dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo=

--===============2366428056340240721==--