--===============2366428056340240721== Content-Type: multipart/alternative; boundary="4e9b44f5a63d4ef8981a8effd2779684" --4e9b44f5a63d4ef8981a8effd2779684 Content-Type: text/plain; charset="ascii" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit graesslin added a comment. Totally stupid question: why import at all into plasma-workspace? We could also make it a standalone repository or does it depend on something else in plasma-workspace? INLINE COMMENTS > CMakeLists.txt:18-23 > +if (X11_FOUND) > + set(taskmanager_LIB_SRCS > + ${taskmanager_LIB_SRCS} > + xwindowtasksmodel.cpp > + ) > +endif() do we want to have X11 conditional? Other areas of Plasma use X11 unconditionally. > CMakeLists.txt:51 > + PRIVATE > + ${Qt5X11Extras_LIBRARIES} > + KF5::IconThemes) Qt5::X11Extras REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, Plasma Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas --4e9b44f5a63d4ef8981a8effd2779684 Content-Type: text/html; charset="ascii" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable
Totally=20s= tupid=20question:=20why=20import=20at=20all=20into=20plasma-workspace?=20We= =20could=20also=20make=20it=20a=20standalone=20repository=20or=20does=20it= =20depend=20on=20something=20else=20in=20plasma-workspace?
do=20we=20want=20to=20have=20X11=20conditiona= l?=20Other=20areas=20of=20Plasma=20use=20X11=20unconditionally.
Qt5::X11Extras