'Re: Review Request 127507: VolumeObject: Add channels and channelVolumes properties'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127507: VolumeObject: Add channels and channelVolumes properties
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2016-03-31 20:26:23
Message-ID: 20160331202623.12706.58159 () mimi ! kde ! org
[Download RAW message or body]

--===============7161407873029272012==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127507/#review94162
-----------------------------------------------------------

Ship it!

Ship It!

- Sebastian Kügler

On March 26, 2016, 8:59 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127507/
> -----------------------------------------------------------
> 
> (Updated March 26, 2016, 8:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Will make it possible to implement per-channel volume control in KCM.
> 
> 
> Diffs
> -----
> 
> src/context.h 8a3a821 
> src/sink.h 7db716b 
> src/sink.cpp d412b7b 
> src/sinkinput.h 4df6f61 
> src/sinkinput.cpp f58d2e1 
> src/source.h 325cde9 
> src/source.cpp fa9f0a0 
> src/sourceoutput.h 74a5da4 
> src/sourceoutput.cpp 8b0ef6c 
> src/volumeobject.h c64a964 
> src/volumeobject.cpp c92d3d9 
> 
> Diff: https://git.reviewboard.kde.org/r/127507/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============7161407873029272012==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127507/">https://git.reviewboard.kde.org/r/127507/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Sebastian Kügler</p>

<br />
<p>On March 26th, 2016, 8:59 p.m. UTC, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated March 26, 2016, 8:59 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Will make it possible to implement per-channel volume \
control in KCM.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/context.h <span style="color: grey">(8a3a821)</span></li>

 <li>src/sink.h <span style="color: grey">(7db716b)</span></li>

 <li>src/sink.cpp <span style="color: grey">(d412b7b)</span></li>

 <li>src/sinkinput.h <span style="color: grey">(4df6f61)</span></li>

 <li>src/sinkinput.cpp <span style="color: grey">(f58d2e1)</span></li>

 <li>src/source.h <span style="color: grey">(325cde9)</span></li>

 <li>src/source.cpp <span style="color: grey">(fa9f0a0)</span></li>

 <li>src/sourceoutput.h <span style="color: grey">(74a5da4)</span></li>

 <li>src/sourceoutput.cpp <span style="color: grey">(8b0ef6c)</span></li>

 <li>src/volumeobject.h <span style="color: grey">(c64a964)</span></li>

 <li>src/volumeobject.cpp <span style="color: grey">(c92d3d9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127507/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7161407873029272012==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 