From kde-panel-devel Thu Mar 31 20:26:23 2016 From: =?utf-8?q?Sebastian_K=C3=BCgler?= Date: Thu, 31 Mar 2016 20:26:23 +0000 To: kde-panel-devel Subject: Re: Review Request 127507: VolumeObject: Add channels and channelVolumes properties Message-Id: <20160331202623.12706.58159 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145945600301020 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3269046747685671640==" --===============3269046747685671640== Content-Type: multipart/alternative; boundary="===============7161407873029272012==" --===============7161407873029272012== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127507/#review94162 ----------------------------------------------------------- Ship it! Ship It! - Sebastian Kügler On March 26, 2016, 8:59 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127507/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 8:59 p.m.) > > > Review request for Plasma. > > > Repository: plasma-pa > > > Description > ------- > > Will make it possible to implement per-channel volume control in KCM. > > > Diffs > ----- > > src/context.h 8a3a821 > src/sink.h 7db716b > src/sink.cpp d412b7b > src/sinkinput.h 4df6f61 > src/sinkinput.cpp f58d2e1 > src/source.h 325cde9 > src/source.cpp fa9f0a0 > src/sourceoutput.h 74a5da4 > src/sourceoutput.cpp 8b0ef6c > src/volumeobject.h c64a964 > src/volumeobject.cpp c92d3d9 > > Diff: https://git.reviewboard.kde.org/r/127507/diff/ > > > Testing > ------- > > > Thanks, > > David Rosca > > --===============7161407873029272012== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127507/

Ship it! 

Ship It!

- Sebastian Kügler


On March 26th, 2016, 8:59 p.m. UTC, David Rosca wrote:

Review request for Plasma.
By David Rosca.

Updated March 26, 2016, 8:59 p.m.

Repository: plasma-pa

Description 

Will make it possible to implement per-channel volume control in KCM.

Diffs

  • src/context.h (8a3a821)
  • src/sink.h (7db716b)
  • src/sink.cpp (d412b7b)
  • src/sinkinput.h (4df6f61)
  • src/sinkinput.cpp (f58d2e1)
  • src/source.h (325cde9)
  • src/source.cpp (fa9f0a0)
  • src/sourceoutput.h (74a5da4)
  • src/sourceoutput.cpp (8b0ef6c)
  • src/volumeobject.h (c64a964)
  • src/volumeobject.cpp (c92d3d9)

View Diff
--===============7161407873029272012==-- --===============3269046747685671640== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============3269046747685671640==--