[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127487: Fix bindings in KCM MuteButton
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2016-03-31 20:23:43
Message-ID: 20160331202343.12706.38557 () mimi ! kde ! org
[Download RAW message or body]
--===============6154740265251523667==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127487/#review94161
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Kügler
On March 24, 2016, 8:37 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127487/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 8:37 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-pa
>
>
> Description
> -------
>
> Assigning value to muted property clears the binding.
>
>
> Diffs
> -----
>
> src/kcm/package/contents/ui/DeviceListItem.qml 979c693
> src/kcm/package/contents/ui/MuteButton.qml 693ab2d
> src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e
>
> Diff: https://git.reviewboard.kde.org/r/127487/diff/
>
>
> Testing
> -------
>
> Click mute -> unmute the device from other app -> mute button have correct state
>
>
> Thanks,
>
> David Rosca
>
>
--===============6154740265251523667==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127487/">https://git.reviewboard.kde.org/r/127487/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Sebastian Kügler</p>
<br />
<p>On March 24th, 2016, 8:37 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 24, 2016, 8:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Assigning value to muted property clears the \
binding.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Click mute -> unmute the device from other app \
-> mute button have correct state</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcm/package/contents/ui/DeviceListItem.qml <span style="color: \
grey">(979c693)</span></li>
<li>src/kcm/package/contents/ui/MuteButton.qml <span style="color: \
grey">(693ab2d)</span></li>
<li>src/kcm/package/contents/ui/StreamListItem.qml <span style="color: \
grey">(7f1d69e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127487/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6154740265251523667==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic