'Re: Review Request 127507: VolumeObject: Add channels and channelVolumes properties'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127507: VolumeObject: Add channels and channelVolumes properties
From:       David Rosca <nowrep () gmail ! com>
Date:       2016-04-01 8:47:31
Message-ID: 20160401084731.12706.93712 () mimi ! kde ! org
[Download RAW message or body]

--===============4416960716951788618==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127507/
-----------------------------------------------------------

(Updated April 1, 2016, 11:47 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit a6b31816af602bc558c79885c527a0ab25dc77ef by David Rosca to \
branch master.

Repository: plasma-pa

Description
-------

Will make it possible to implement per-channel volume control in KCM.

Diffs
-----

  src/context.h 8a3a821 
  src/sink.h 7db716b 
  src/sink.cpp d412b7b 
  src/sinkinput.h 4df6f61 
  src/sinkinput.cpp f58d2e1 
  src/source.h 325cde9 
  src/source.cpp fa9f0a0 
  src/sourceoutput.h 74a5da4 
  src/sourceoutput.cpp 8b0ef6c 
  src/volumeobject.h c64a964 
  src/volumeobject.cpp c92d3d9 

Diff: https://git.reviewboard.kde.org/r/127507/diff/

Testing
-------

Thanks,

David Rosca

--===============4416960716951788618==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127507/">https://git.reviewboard.kde.org/r/127507/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated April 1, 2016, 11:47 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit a6b31816af602bc558c79885c527a0ab25dc77ef by David \
Rosca to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Will make it possible to implement per-channel volume \
control in KCM.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/context.h <span style="color: grey">(8a3a821)</span></li>

 <li>src/sink.h <span style="color: grey">(7db716b)</span></li>

 <li>src/sink.cpp <span style="color: grey">(d412b7b)</span></li>

 <li>src/sinkinput.h <span style="color: grey">(4df6f61)</span></li>

 <li>src/sinkinput.cpp <span style="color: grey">(f58d2e1)</span></li>

 <li>src/source.h <span style="color: grey">(325cde9)</span></li>

 <li>src/source.cpp <span style="color: grey">(fa9f0a0)</span></li>

 <li>src/sourceoutput.h <span style="color: grey">(74a5da4)</span></li>

 <li>src/sourceoutput.cpp <span style="color: grey">(8b0ef6c)</span></li>

 <li>src/volumeobject.h <span style="color: grey">(c64a964)</span></li>

 <li>src/volumeobject.cpp <span style="color: grey">(c92d3d9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127507/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4416960716951788618==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 