[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 125774: [Lock Screen] Use org.kde.plasma.private.sessions for User Switcher
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-10-30 12:09:15
Message-ID: 20151030120915.27229.10643 () mimi ! kde ! org
[Download RAW message or body]
--===============8492130926511857315==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125774/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 12:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Martin Gräßlin.
Changes
-------
Submitted with commit 987f4f76030d1dce5729285df3eb595d50951b04 by Bhushan Shah on \
behalf of Kai Uwe Broulik to branch master.
Repository: plasma-workspace
Description
-------
This migrates the Lock Screen qml from using ksmserver's Session model to the new one \
provided by components.
Changes:
* It now shows the user avatar and full name in the user switcher
* It only offers to switch sessions if there are any
I would like to remove the sessions model stuff from the screenlocker greeter (given \
it's unused then and would bitrot), however we probably cannot do this or else we \
break 3rd party look and feel packages.
Diffs
-----
lookandfeel/contents/components/UserSelect.qml 007a118
lookandfeel/contents/lockscreen/ChangeSession.qml 58974f6
lookandfeel/contents/lockscreen/LockScreen.qml 3a78a5f
lookandfeel/contents/lockscreen/MainBlock.qml 6d39a86
Diff: https://git.reviewboard.kde.org/r/125774/diff/
Testing
-------
Switching users (both to other X and TTY) as well as creating a new session works.
The model does not update, however, meaning if you log in elsewhere the "Switch \
session" button won't magically appear while the screen is locked. I don't think the \
old model did that either.
Also, when cancelling the user switch, it will scroll the view back to the first item \
so you're not stranded with two buttons with the user scrolled out of the view with \
no indication (I think there was a bug report and the code was there, it just tried \
to reset the wrong index property)
Thanks,
Kai Uwe Broulik
--===============8492130926511857315==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125774/">https://git.reviewboard.kde.org/r/125774/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2015, 12:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 987f4f76030d1dce5729285df3eb595d50951b04 by \
Bhushan Shah on behalf of Kai Uwe Broulik to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This migrates the Lock Screen qml from using \
ksmserver's Session model to the new one provided by components.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Changes:</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
now shows the user avatar and full name in the user switcher</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It only offers to switch sessions if \
there are any</p> </li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I would like to remove the sessions model stuff from \
the screenlocker greeter (given it's unused then and would bitrot), however we \
probably cannot do this or else we break 3rd party look and feel packages.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Switching users (both to other X and TTY) as well as \
creating a new session works. The model does not update, however, meaning if you log \
in elsewhere the "Switch session" button won't magically appear while the screen is \
locked. I don't think the old model did that either.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, \
when cancelling the user switch, it will scroll the view back to the first item so \
you're not stranded with two buttons with the user scrolled out of the view with no \
indication (I think there was a bug report and the code was there, it just tried to \
reset the wrong index property)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/components/UserSelect.qml <span style="color: \
grey">(007a118)</span></li>
<li>lookandfeel/contents/lockscreen/ChangeSession.qml <span style="color: \
grey">(58974f6)</span></li>
<li>lookandfeel/contents/lockscreen/LockScreen.qml <span style="color: \
grey">(3a78a5f)</span></li>
<li>lookandfeel/contents/lockscreen/MainBlock.qml <span style="color: \
grey">(6d39a86)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125774/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8492130926511857315==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic