'Re: Review Request 125622: Use better guard against recursion when changing volume with sliders'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125622: Use better guard against recursion when changing volume with sliders
From:       "David Rosca" <nowrep () gmail ! com>
Date:       2015-10-30 11:54:39
Message-ID: 20151030115439.14097.25312 () mimi ! kde ! org
[Download RAW message or body]

--===============7076899510655982874==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125622/
-----------------------------------------------------------

(Updated Oct. 30, 2015, 5:54 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-pa

Description
-------

As noted in https://git.reviewboard.kde.org/r/125088/, this should fix acessibility \
on volume sliders. This also fixes changing the volume with keyboard (when slider has \
focus).

Diffs
-----

  applet/contents/ui/ListItemBase.qml 54f6eb0 
  src/kcm/package/contents/ui/VolumeSlider.qml da77315 

Diff: https://git.reviewboard.kde.org/r/125622/diff/

Testing
-------

Changing volume in applet still works + it fixes changing volume in kcm (i broke it \
with last commit - there is no setVolume() in kcm VolumeSlider).

Thanks,

David Rosca

--===============7076899510655982874==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125622/">https://git.reviewboard.kde.org/r/125622/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated Oct. 30, 2015, 5:54 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As noted in https://git.reviewboard.kde.org/r/125088/, \
this should fix acessibility on volume sliders. This also fixes changing the volume \
with keyboard (when slider has focus).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Changing volume in applet still works + it fixes \
changing volume in kcm (i broke it with last commit - there is no setVolume() in kcm \
VolumeSlider).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applet/contents/ui/ListItemBase.qml <span style="color: \
grey">(54f6eb0)</span></li>

 <li>src/kcm/package/contents/ui/VolumeSlider.qml <span style="color: \
grey">(da77315)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125622/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7076899510655982874==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 