--===============5900268788910220617== Content-Type: multipart/alternative; boundary="===============8492130926511857315==" --===============8492130926511857315== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125774/ ----------------------------------------------------------- (Updated Oct. 30, 2015, 12:09 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Changes ------- Submitted with commit 987f4f76030d1dce5729285df3eb595d50951b04 by Bhushan Shah on behalf of Kai Uwe Broulik to branch master. Repository: plasma-workspace Description ------- This migrates the Lock Screen qml from using ksmserver's Session model to the new one provided by components. Changes: * It now shows the user avatar and full name in the user switcher * It only offers to switch sessions if there are any I would like to remove the sessions model stuff from the screenlocker greeter (given it's unused then and would bitrot), however we probably cannot do this or else we break 3rd party look and feel packages. Diffs ----- lookandfeel/contents/components/UserSelect.qml 007a118 lookandfeel/contents/lockscreen/ChangeSession.qml 58974f6 lookandfeel/contents/lockscreen/LockScreen.qml 3a78a5f lookandfeel/contents/lockscreen/MainBlock.qml 6d39a86 Diff: https://git.reviewboard.kde.org/r/125774/diff/ Testing ------- Switching users (both to other X and TTY) as well as creating a new session works. The model does not update, however, meaning if you log in elsewhere the "Switch session" button won't magically appear while the screen is locked. I don't think the old model did that either. Also, when cancelling the user switch, it will scroll the view back to the first item so you're not stranded with two buttons with the user scrolled out of the view with no indication (I think there was a bug report and the code was there, it just tried to reset the wrong index property) Thanks, Kai Uwe Broulik --===============8492130926511857315== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125774/

This change has been marked as submitted.

Review request for Plasma and Martin Gräßlin.
By Kai Uwe Broulik.

Updated Oct. 30, 2015, 12:09 p.m.

Changes

Submitted with commit 987f4f76030d1dce5729285df3eb595d50951b04 by Bhushan Shah on behalf of Kai Uwe Broulik to branch master.
Repository: plasma-workspace

Description 

This migrates the Lock Screen qml from using ksmserver's Session model to the new one provided by components.


Changes:


    

  • 

    It now shows the user avatar and full name in the user switcher
    

    • 

  • 

    It only offers to switch sessions if there are any
    

    • 



I would like to remove the sessions model stuff from the screenlocker greeter (given it's unused then and would bitrot), however we probably cannot do this or else we break 3rd party look and feel packages.

Testing 

Switching users (both to other X and TTY) as well as creating a new session works.
The model does not update, however, meaning if you log in elsewhere the "Switch session" button won't magically appear while the screen is locked. I don't think the old model did that either.


Also, when cancelling the user switch, it will scroll the view back to the first item so you're not stranded with two buttons with the user scrolled out of the view with no indication (I think there was a bug report and the code was there, it just tried to reset the wrong index property)

Diffs

  • lookandfeel/contents/components/UserSelect.qml (007a118)
  • lookandfeel/contents/lockscreen/ChangeSession.qml (58974f6)
  • lookandfeel/contents/lockscreen/LockScreen.qml (3a78a5f)
  • lookandfeel/contents/lockscreen/MainBlock.qml (6d39a86)

View Diff
--===============8492130926511857315==-- --===============5900268788910220617== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5900268788910220617==--