[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-10-30 12:09:15
Message-ID: 20151030120915.14097.94878 () mimi ! kde ! org
[Download RAW message or body]
--===============4599325411924710707==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124980/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 12:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Martin Gräßlin.
Changes
-------
Submitted with commit 667ed80cbe9866c87f238cd1a54516820fb8da83 by Bhushan Shah on \
behalf of Kai Uwe Broulik to branch master.
Repository: plasma-workspace
Description
-------
This way it can be used in the lock screen, user switcher, and a user switcher \
plasmoid I'm planning.
Compared to the one in the lock screen it can also get the user's full name and \
avatar, and some other information.
Perhaps we could also try to have it wait for the screen to actually lock before \
switching sessions?
Diffs
-----
components/CMakeLists.txt 21fc61c
components/sessionsprivate/CMakeLists.txt PRE-CREATION
components/sessionsprivate/qmldir PRE-CREATION
components/sessionsprivate/sessionsmodel.h PRE-CREATION
components/sessionsprivate/sessionsmodel.cpp PRE-CREATION
components/sessionsprivate/sessionsprivateplugin.h PRE-CREATION
components/sessionsprivate/sessionsprivateplugin.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124980/diff/
Testing
-------
Lists my sessions, allows to switch between them and start new ones. Locking when \
creating a new session is missing.
Thanks,
Kai Uwe Broulik
--===============4599325411924710707==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124980/">https://git.reviewboard.kde.org/r/124980/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2015, 12:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 667ed80cbe9866c87f238cd1a54516820fb8da83 by \
Bhushan Shah on behalf of Kai Uwe Broulik to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This way it can be used in the lock screen, user \
switcher, and a user switcher plasmoid I'm planning.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Compared to the one in the lock screen it can also get the user's full name \
and avatar, and some other information.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Perhaps we could also \
try to have it wait for the screen to actually lock before switching \
sessions?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Lists my sessions, allows to switch between them and \
start new ones. Locking when creating a new session is missing.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>components/CMakeLists.txt <span style="color: grey">(21fc61c)</span></li>
<li>components/sessionsprivate/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/sessionsprivate/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/sessionsprivate/sessionsmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/sessionsprivate/sessionsmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/sessionsprivate/sessionsprivateplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/sessionsprivate/sessionsprivateplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124980/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4599325411924710707==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic