'Re: Review Request 117746: Don't make blocking dbus calls from KDED for appmenu.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117746: Don't make blocking dbus calls from KDED for appmenu.
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-08-31 10:59:44
Message-ID: 20150831105944.10622.22252 () mimi ! kde ! org
[Download RAW message or body]

--===============8610608749812360076==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117746/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 10:59 a.m.)

Status
------

This change has been discarded.

Review request for Plasma and Cedric Bellegarde.

Repository: kde-workspace

Description
-------

    Avoid call to blocking QDBusInterface

    QDBusInterface is an evil command with a secret blocking call inside
    to introspect the interface.

    Apps can get in a blocked state where they query the kded
    for information (such as testing if we have a network, or loading the
    timezone) and the kded is blocked waiting for the application trying
    to load the menus.

    This results in apps and kded being frozen.

Update: I want to put this in the stable branch

Diffs
-----

  appmenu/menuimporter.cpp b55b7d3 

Diff: https://git.reviewboard.kde.org/r/117746/diff/

Testing
-------

I have *NOT* tested this and am unable to.

I would appreciate it if someone else could check everything still works.

Thanks,

David Edmundson

--===============8610608749812360076==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117746/">https://git.reviewboard.kde.org/r/117746/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Cedric Bellegarde.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Aug. 31, 2015, 10:59 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Avoid call to blocking QDBusInterface  
    QDBusInterface is an evil command with a secret blocking call inside
    to introspect the interface.

    Apps can get in a blocked state where they query the kded
    for information (such as testing if we have a network, or loading the
    timezone) and the kded is blocked waiting for the application trying
    to load the menus.

    This results in apps and kded being frozen.

Update: I want to put this in the stable branch</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have *NOT* tested this and am unable to.

I would appreciate it if someone else could check everything still works.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>appmenu/menuimporter.cpp <span style="color: grey">(b55b7d3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117746/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8610608749812360076==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 