'Re: Review Request 105112: kickoff: save recent applications list on every change to it'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 105112: kickoff: save recent applications list on every change to it
From:       "Andriy Gapon" <avg () icyb ! net ! ua>
Date:       2015-08-31 11:01:26
Message-ID: 20150831110126.10622.38846 () mimi ! kde ! org
[Download RAW message or body]

--===============0071923908956868956==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105112/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 11:01 a.m.)

Status
------

This change has been discarded.

Review request for Plasma and Torrie Fischer.

Bugs: 206511
    http://bugs.kde.org/show_bug.cgi?id=206511

Repository: kde-workspace

Description
-------

Currently recent applications list in kickoff is saved only when kickoff gracefully \
exits.  This could be a minor annoyance when X/KDE/plasma crashes.  I think that \
saving the list on every update to it should be a good idea.  It should be a low \
overhead too, because the list changes only when a user launches an application via \
KDE.

Diffs
-----

  plasma/desktop/applets/kickoff/core/recentapplications.cpp 3e05389 

Diff: https://git.reviewboard.kde.org/r/105112/diff/

Testing
-------

Thanks,

Andriy Gapon

--===============0071923908956868956==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/105112/">https://git.reviewboard.kde.org/r/105112/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Torrie Fischer.</div>
<div>By Andriy Gapon.</div>

<p style="color: grey;"><i>Updated Aug. 31, 2015, 11:01 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=206511">206511</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently recent applications list in kickoff is saved only when kickoff \
gracefully exits.  This could be a minor annoyance when X/KDE/plasma crashes.  I \
think that saving the list on every update to it should be a good idea.  It should be \
a low overhead too, because the list changes only when a user launches an application \
via KDE.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/kickoff/core/recentapplications.cpp <span style="color: \
grey">(3e05389)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/105112/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0071923908956868956==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 