'Re: Review Request 107881: Rename krunner plugin konsolesessions to konsoleprofiles'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 107881: Rename krunner plugin konsolesessions to konsoleprofiles
From:       "Jekyll Wu" <adaptee () gmail ! com>
Date:       2015-08-31 10:57:46
Message-ID: 20150831105746.10622.40718 () mimi ! kde ! org
[Download RAW message or body]

--===============3472906269444296431==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107881/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 10:57 a.m.)

Status
------

This change has been discarded.

Review request for Plasma.

Repository: kdeplasma-addons

Description
-------

Konsole currently does not provide the session feature like in kate and konqueror. \
That plugin works with konsole profiles, not the not-reimplemented-yet konsole \
sessions. 

Also, the equivalent plasmoid is properly named as "konsole profiles". 

Diffs
-----

  runners/CMakeLists.txt bb4b491 
  runners/konsoleprofiles/CMakeLists.txt PRE-CREATION 
  runners/konsoleprofiles/Messages.sh PRE-CREATION 
  runners/konsoleprofiles/konsoleprofiles.cpp PRE-CREATION 
  runners/konsoleprofiles/konsoleprofiles.desktop PRE-CREATION 
  runners/konsoleprofiles/konsoleprofiles.h PRE-CREATION 
  runners/konsoleprofiles/konsolesessions_renamed_to_konsoleprofiles.upd PRE-CREATION \
  runners/konsolesessions/CMakeLists.txt c1d5cea 
  runners/konsolesessions/Messages.sh 5f03904 
  runners/konsolesessions/konsolesessions.cpp ed7550a 
  runners/konsolesessions/konsolesessions.desktop 7d9ce5a 
  runners/konsolesessions/konsolesessions.h a98c253 

Diff: https://git.reviewboard.kde.org/r/107881/diff/

Testing
-------

Thanks,

Jekyll Wu

--===============3472906269444296431==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/107881/">https://git.reviewboard.kde.org/r/107881/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>

<p style="color: grey;"><i>Updated Aug. 31, 2015, 10:57 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Konsole currently does not provide the session feature like in kate and \
konqueror. That plugin works with konsole profiles, not the not-reimplemented-yet \
konsole sessions. 

Also, the equivalent plasmoid is properly named as &quot;konsole profiles&quot;. \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>runners/CMakeLists.txt <span style="color: grey">(bb4b491)</span></li>

 <li>runners/konsoleprofiles/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>runners/konsoleprofiles/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>runners/konsoleprofiles/konsoleprofiles.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>runners/konsoleprofiles/konsoleprofiles.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>runners/konsoleprofiles/konsoleprofiles.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>runners/konsoleprofiles/konsolesessions_renamed_to_konsoleprofiles.upd <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>runners/konsolesessions/CMakeLists.txt <span style="color: \
grey">(c1d5cea)</span></li>

 <li>runners/konsolesessions/Messages.sh <span style="color: \
grey">(5f03904)</span></li>

 <li>runners/konsolesessions/konsolesessions.cpp <span style="color: \
grey">(ed7550a)</span></li>

 <li>runners/konsolesessions/konsolesessions.desktop <span style="color: \
grey">(7d9ce5a)</span></li>

 <li>runners/konsolesessions/konsolesessions.h <span style="color: \
grey">(a98c253)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/107881/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3472906269444296431==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 