--===============1031912865319875463== Content-Type: multipart/alternative; boundary="===============8610608749812360076==" --===============8610608749812360076== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117746/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 10:59 a.m.) Status ------ This change has been discarded. Review request for Plasma and Cedric Bellegarde. Repository: kde-workspace Description ------- Avoid call to blocking QDBusInterface QDBusInterface is an evil command with a secret blocking call inside to introspect the interface. Apps can get in a blocked state where they query the kded for information (such as testing if we have a network, or loading the timezone) and the kded is blocked waiting for the application trying to load the menus. This results in apps and kded being frozen. Update: I want to put this in the stable branch Diffs ----- appmenu/menuimporter.cpp b55b7d3 Diff: https://git.reviewboard.kde.org/r/117746/diff/ Testing ------- I have *NOT* tested this and am unable to. I would appreciate it if someone else could check everything still works. Thanks, David Edmundson --===============8610608749812360076== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117746/

This change has been discarded.

Review request for Plasma and Cedric Bellegarde.

By David Edmundson.

Updated Aug. 31, 2015, 10:59 a.m.

Repository: kde-workspace

Description

    Avoid call to blocking QDBusInterface
    
    QDBusInterface is an evil command with a secret blocking call inside
    to introspect the interface.
    
    Apps can get in a blocked state where they query the kded
    for information (such as testing if we have a network, or loading the
    timezone) and the kded is blocked waiting for the application trying
    to load the menus.
    
    This results in apps and kded being frozen.


Update: I want to put this in the stable branch

Testing

I have *NOT* tested this and am unable to.

I would appreciate it if someone else could check everything still works.

Diffs

appmenu/menuimporter.cpp (b55b7d3)

View Diff

--===============8610608749812360076==-- --===============1031912865319875463== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1031912865319875463==--