'Re: Review Request 124555: use kwayland to move Plasma::Dialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124555: use kwayland to move Plasma::Dialog
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-07-31 19:56:29
Message-ID: 20150731195629.31864.26833 () mimi ! kde ! org
[Download RAW message or body]

--===============0168778334628266983==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On July 31, 2015, 7:26 p.m., Martin Gräßlin wrote:
> > The copy of dialog.h somehow scares me - is there no other way? I'm afraid it \
> > will totally get out of sync especially given that the release cycles are not \
> > synced.

ah, that copy is already around.. an alternative is to completely give up and install \
the headers so that's officially "released". we won't get to change abi ever anyways \
i guess since stuff from that library is already used too much around

- Marco

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124555/#review83262
-----------------------------------------------------------

On July 31, 2015, 3:23 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124555/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 3:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> since we can't subclass Dialog (created from QML) inject a class that will control \
> it with event filters from the shell (in an eventfilter as well installed on the \
> qapp) 
> 
> Diffs
> -----
> 
> shell/CMakeLists.txt 3cfc84b 
> shell/plasmaquick/dialog.h PRE-CREATION 
> shell/shellcorona.h 9e93844 
> shell/shellcorona.cpp fbffbb0 
> shell/waylanddialogfilter.h PRE-CREATION 
> shell/waylanddialogfilter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 

--===============0168778334628266983==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124555/">https://git.reviewboard.kde.org/r/124555/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 31st, 2015, 7:26 p.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The copy of dialog.h somehow scares me - is there no \
other way? I'm afraid it will totally get out of sync especially given that the \
release cycles are not synced.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ah, \
that copy is already around.. an alternative is to completely give up and install the \
headers so that's officially "released". we won't get to change abi ever anyways i \
guess since stuff from that library is already used too much around</p></pre> <br />

<p>- Marco</p>

<br />
<p>On July 31st, 2015, 3:23 p.m. UTC, Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated July 31, 2015, 3:23 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">since we can't subclass Dialog (created from QML) \
inject a class that will control it with event filters from the shell (in an \
eventfilter as well installed on the qapp)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/CMakeLists.txt <span style="color: grey">(3cfc84b)</span></li>

 <li>shell/plasmaquick/dialog.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>shell/shellcorona.h <span style="color: grey">(9e93844)</span></li>

 <li>shell/shellcorona.cpp <span style="color: grey">(fbffbb0)</span></li>

 <li>shell/waylanddialogfilter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>shell/waylanddialogfilter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124555/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0168778334628266983==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 