[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124555: use kwayland to move Plasma::Dialog
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-07-31 19:26:05
Message-ID: 20150731192605.31864.12179 () mimi ! kde ! org
[Download RAW message or body]
--===============5297484500305794837==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124555/#review83262
-----------------------------------------------------------
The copy of dialog.h somehow scares me - is there no other way? I'm afraid it will \
totally get out of sync especially given that the release cycles are not synced.
shell/shellcorona.cpp (line 213)
<https://git.reviewboard.kde.org/r/124555/#comment57493>
instead of casting twice (see line 217) store the pointer to Dialog in a temp \
variable?
- Martin Gräßlin
On Juli 31, 2015, 5:23 nachm., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124555/
> -----------------------------------------------------------
>
> (Updated Juli 31, 2015, 5:23 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> since we can't subclass Dialog (created from QML) inject a class that will control \
> it with event filters from the shell (in an eventfilter as well installed on the \
> qapp)
>
> Diffs
> -----
>
> shell/CMakeLists.txt 3cfc84b
> shell/plasmaquick/dialog.h PRE-CREATION
> shell/shellcorona.h 9e93844
> shell/shellcorona.cpp fbffbb0
> shell/waylanddialogfilter.h PRE-CREATION
> shell/waylanddialogfilter.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124555/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============5297484500305794837==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124555/">https://git.reviewboard.kde.org/r/124555/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
copy of dialog.h somehow scares me - is there no other way? I'm afraid it will \
totally get out of sync especially given that the release cycles are not \
synced.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124555/diff/1/?file=388874#file388874line213" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/shellcorona.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">213</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qobject_cast</span><span class="o"><</span><span \
class="n">PlasmaQuick</span><span class="o">::</span><span class="n">Dialog</span> \
<span class="o">*></span><span class="p">(</span><span \
class="n">watched</span><span class="p">))</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">instead of casting twice (see line 217) store the pointer to Dialog in a \
temp variable?</p></pre> </div>
</div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On Juli 31st, 2015, 5:23 nachm. CEST, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Juli 31, 2015, 5:23 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">since we can't subclass Dialog (created from QML) \
inject a class that will control it with event filters from the shell (in an \
eventfilter as well installed on the qapp)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/CMakeLists.txt <span style="color: grey">(3cfc84b)</span></li>
<li>shell/plasmaquick/dialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/shellcorona.h <span style="color: grey">(9e93844)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(fbffbb0)</span></li>
<li>shell/waylanddialogfilter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/waylanddialogfilter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124555/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5297484500305794837==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic