From kde-panel-devel Fri Jul 31 19:56:29 2015 From: "Marco Martin" Date: Fri, 31 Jul 2015 19:56:29 +0000 To: kde-panel-devel Subject: Re: Review Request 124555: use kwayland to move Plasma::Dialog Message-Id: <20150731195629.31864.26833 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143837260610352 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8660924186533582197==" --===============8660924186533582197== Content-Type: multipart/alternative; boundary="===============0168778334628266983==" --===============0168778334628266983== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On July 31, 2015, 7:26 p.m., Martin Gräßlin wrote: > > The copy of dialog.h somehow scares me - is there no other way? I'm afraid it will totally get out of sync especially given that the release cycles are not synced. ah, that copy is already around.. an alternative is to completely give up and install the headers so that's officially "released". we won't get to change abi ever anyways i guess since stuff from that library is already used too much around - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124555/#review83262 ----------------------------------------------------------- On July 31, 2015, 3:23 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124555/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 3:23 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > since we can't subclass Dialog (created from QML) inject a class that will control it with event filters from the shell (in an eventfilter as well installed on the qapp) > > > Diffs > ----- > > shell/CMakeLists.txt 3cfc84b > shell/plasmaquick/dialog.h PRE-CREATION > shell/shellcorona.h 9e93844 > shell/shellcorona.cpp fbffbb0 > shell/waylanddialogfilter.h PRE-CREATION > shell/waylanddialogfilter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124555/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > > --===============0168778334628266983== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124555/

On July 31st, 2015, 7:26 p.m. UTC, Martin Gräßlin wrote:

The copy of dialog.h somehow scares me - is there no other way? I'm afraid it will totally get out of sync especially given that the release cycles are not synced.

ah, that copy is already around.. an alternative is to completely give up and install the headers so that's officially "released". we won't get to change abi ever anyways i guess since stuff from that library is already used too much around

- Marco

On July 31st, 2015, 3:23 p.m. UTC, Marco Martin wrote:

Review request for Plasma.

By Marco Martin.

Updated July 31, 2015, 3:23 p.m.

Repository: plasma-workspace

Description

since we can't subclass Dialog (created from QML) inject a class that will control it with event filters from the shell (in an eventfilter as well installed on the qapp)

Diffs

shell/CMakeLists.txt (3cfc84b)
shell/plasmaquick/dialog.h (PRE-CREATION)
shell/shellcorona.h (9e93844)
shell/shellcorona.cpp (fbffbb0)
shell/waylanddialogfilter.h (PRE-CREATION)
shell/waylanddialogfilter.cpp (PRE-CREATION)

--===============0168778334628266983==-- --===============8660924186533582197== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8660924186533582197==--