'Review Request 124571: add features from kcm_useraccounts'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 124571: add features from kcm_useraccounts
From:       "Jonathan Riddell" <jr () jriddell ! org>
Date:       2015-07-31 20:53:55
Message-ID: 20150731205355.31864.18459 () mimi ! kde ! org
[Download RAW message or body]

--===============1866398620051050161==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124571/
-----------------------------------------------------------

Review request for Plasma.

Repository: user-manager

Description
-------

Save settings with m_kEmailSettings as well to replace kcm_useraccounts
add symlink in ~/.face.icon the file used by some login managers

with this we can get rid of kcm_useraccounts which just duplicates it

Diffs
-----

  src/accountinfo.cpp 78fe969 
  src/lib/accountmodel.h 331c131 
  src/lib/accountmodel.cpp 558aa6b 

Diff: https://git.reviewboard.kde.org/r/124571/diff/

Testing
-------

edited user settings and checked ~/.config/emailsettingsrc

edited user settings and checked ~/.face*

Thanks,

Jonathan Riddell

--===============1866398620051050161==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124571/">https://git.reviewboard.kde.org/r/124571/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Jonathan Riddell.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
user-manager
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Save settings with m_kEmailSettings as well to replace \
kcm_useraccounts add symlink in ~/.face.icon the file used by some login managers</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">with this we can get rid of kcm_useraccounts which \
just duplicates it</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">edited user settings and checked \
~/.config/emailsettingsrc</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">edited user settings and checked \
~/.face*</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/accountinfo.cpp <span style="color: grey">(78fe969)</span></li>

 <li>src/lib/accountmodel.h <span style="color: grey">(331c131)</span></li>

 <li>src/lib/accountmodel.cpp <span style="color: grey">(558aa6b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124571/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1866398620051050161==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 