'Re: Review Request 124543: Don't horizontally shift dialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124543: Don't horizontally shift dialog
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-07-31 19:21:53
Message-ID: 20150731192153.31864.53202 () mimi ! kde ! org
[Download RAW message or body]

--===============8611681835697437151==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Juli 31, 2015, 12:52 nachm., Marco Martin wrote:
> > did you test it with left and right edge panels?

Didn't notice anything unusual. It also fixes the QueryDialog being shifted to the \
left corner of the screen if I put the lock_logout applet into a panel and ask it to \
suspend.

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124543/#review83230
-----------------------------------------------------------

On Juli 31, 2015, 8:57 vorm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124543/
> -----------------------------------------------------------
> 
> (Updated Juli 31, 2015, 8:57 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When placing an applet on the far right corner of the screen (eg. analog clock), \
> its popup would appear diagonally shifted to the left rather than at the screen \
> edge. 
> 
> Diffs
> -----
> 
> src/plasmaquick/dialog.cpp 6770c1a 
> 
> Diff: https://git.reviewboard.kde.org/r/124543/diff/
> 
> 
> Testing
> -------
> 
> It no longer does that but I don't know what other implications this voodoo has. On \
> the other hand, the dialogs usually pop out at the top or bottom (for free \
> floating) and this stuff isn't touched, just the horizontal shifting removed. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============8611681835697437151==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124543/">https://git.reviewboard.kde.org/r/124543/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Juli 31st, 2015, 12:52 nachm. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">did you test it with left and right edge \
panels?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Didn't notice anything unusual. It also fixes the QueryDialog being shifted \
to the left corner of the screen if I put the lock_logout applet into a panel and ask \
it to suspend.</p></pre> <br />

<p>- Kai Uwe</p>

<br />
<p>On Juli 31st, 2015, 8:57 vorm. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Juli 31, 2015, 8:57 vorm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When placing an applet on the far right corner of the \
screen (eg. analog clock), its popup would appear diagonally shifted to the left \
rather than at the screen edge.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It no longer does that but I don't know what other \
implications this voodoo has. On the other hand, the dialogs usually pop out at the \
top or bottom (for free floating) and this stuff isn't touched, just the horizontal \
shifting removed.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasmaquick/dialog.cpp <span style="color: grey">(6770c1a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124543/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8611681835697437151==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 